Page MenuHomePhabricator

Make InlineCommentQueries more robust/consistent
ClosedPublic

Authored by epriestley on May 7 2020, 5:56 PM.
Tags
None
Referenced Files
F19031333: D21227.diff
Tue, Nov 25, 12:07 AM
F19015073: D21227.diff
Sat, Nov 22, 10:31 PM
F19000165: D21227.diff
Thu, Nov 20, 11:05 PM
F18811717: D21227.id.diff
Oct 20 2025, 4:31 AM
F18810566: D21227.diff
Oct 19 2025, 10:14 PM
F18807845: D21227.diff
Oct 19 2025, 3:30 AM
F18620215: D21227.id.diff
Sep 15 2025, 4:32 AM
F18617773: D21227.diff
Sep 14 2025, 10:06 PM
Subscribers
None

Details

Summary

Ref T13513. Improve consistency and robustness of the "InlineComment" queries.

The only real change here is that these queries now implicitly add a clause for selecting inlines ("pathID IS NULL" or "changesetID IS NULL").

Test Plan

Browed, created, edited, and submitted inlines.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:00 PM
This revision was automatically updated to reflect the committed changes.