Page MenuHomePhabricator

Make InlineCommentQueries more robust/consistent
ClosedPublic

Authored by epriestley on Thu, May 7, 5:56 PM.

Details

Summary

Ref T13513. Improve consistency and robustness of the "InlineComment" queries.

The only real change here is that these queries now implicitly add a clause for selecting inlines ("pathID IS NULL" or "changesetID IS NULL").

Test Plan

Browed, created, edited, and submitted inlines.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 7, 5:56 PM
epriestley requested review of this revision.Thu, May 7, 5:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 7, 11:00 PM
This revision was automatically updated to reflect the committed changes.