Page MenuHomePhabricator
Differential D21224

Remove the obsolete "DiffusionInlineCommentPreviewController"
ClosedPublic
Actions

Authored by epriestley on May 6 2020, 3:36 PM.
Tags
None
Referenced Files
F19505458: D21224.diff
Fri, Jan 9, 11:47 AM
F19096055: D21224.id.diff
Dec 4 2025, 7:56 AM
F19093543: D21224.diff
Dec 3 2025, 9:49 PM
F18922491: D21224.id.diff
Nov 9 2025, 3:30 PM
F18864703: D21224.id.diff
Nov 3 2025, 8:21 AM
F18863107: D21224.diff
Nov 2 2025, 9:59 PM
F18810777: D21224.id50549.diff
Oct 19 2025, 11:22 PM
F18736912: D21224.id.diff
Oct 1 2025, 8:13 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController"
Summary

Ref T13513. This controller was obsoleted by EditEngine and appears unreachable without explicitly typing the URL.

Test Plan
  • Grepped for the route, didn't find any hits.
  • Deleted the controller, successfully previewed comments in Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
iquery1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24364
Build 33564: Run Core Tests
Build 33563: arc lint + arc unit

Event Timeline

epriestley created this revision.May 6 2020, 3:36 PM
Harbormaster completed remote builds in B24364: Diff 50548.May 6 2020, 3:37 PM
epriestley requested review of this revision.May 6 2020, 3:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 6 2020, 5:13 PM
Closed by commit rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController".

Revision Contents
Changeset List

Diff 50548

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionInlineCommentPreviewController.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentPreviewController.php

Loading...
Phabricator · Built by Phacility