Page MenuHomePhabricator
Differential D21224

Remove the obsolete "DiffusionInlineCommentPreviewController"
ClosedPublic
Actions

Authored by epriestley on May 6 2020, 3:36 PM.
Tags
None
Referenced Files
F15473201: D21224.id50549.diff
Sat, Apr 5, 8:07 PM
F15470936: D21224.id50549.diff
Sat, Apr 5, 2:16 AM
F15470328: D21224.id50549.diff
Fri, Apr 4, 9:34 PM
F15456468: D21224.id50548.diff
Sun, Mar 30, 9:56 AM
F15454527: D21224.id50549.diff
Sat, Mar 29, 6:58 PM
F15453132: D21224.id.diff
Sat, Mar 29, 9:39 AM
F15451821: D21224.diff
Sat, Mar 29, 12:00 AM
F15436831: D21224.id50549.diff
Tue, Mar 25, 4:38 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController"
Summary

Ref T13513. This controller was obsoleted by EditEngine and appears unreachable without explicitly typing the URL.

Test Plan
  • Grepped for the route, didn't find any hits.
  • Deleted the controller, successfully previewed comments in Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
iquery1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24364
Build 33564: Run Core Tests
Build 33563: arc lint + arc unit

Event Timeline

epriestley created this revision.May 6 2020, 3:36 PM
Harbormaster completed remote builds in B24364: Diff 50548.May 6 2020, 3:37 PM
epriestley requested review of this revision.May 6 2020, 3:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 6 2020, 5:13 PM
Closed by commit rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController".

Revision Contents
Changeset List

Diff 50548

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionInlineCommentPreviewController.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentPreviewController.php

Loading...
Phabricator · Built by Phacility