Page MenuHomePhabricator
Differential D21224

Remove the obsolete "DiffusionInlineCommentPreviewController"
ClosedPublic
Actions

Authored by epriestley on May 6 2020, 3:36 PM.
Tags
None
Referenced Files
F18425139: D21224.diff
Sat, Aug 30, 9:37 PM
F18112317: D21224.diff
Tue, Aug 12, 4:22 PM
F18101092: D21224.id.diff
Sat, Aug 9, 12:19 PM
F18096005: D21224.id50549.diff
Fri, Aug 8, 3:42 AM
F18081511: D21224.diff
Tue, Aug 5, 12:43 AM
F17924523: D21224.id.diff
Jul 30 2025, 10:05 AM
F17917315: D21224.diff
Jul 29 2025, 11:28 PM
Unknown Object (File)
Jun 5 2025, 4:53 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController"
Summary

Ref T13513. This controller was obsoleted by EditEngine and appears unreachable without explicitly typing the URL.

Test Plan
  • Grepped for the route, didn't find any hits.
  • Deleted the controller, successfully previewed comments in Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 6 2020, 3:36 PM
Harbormaster completed remote builds in B24364: Diff 50548.May 6 2020, 3:37 PM
epriestley requested review of this revision.May 6 2020, 3:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 6 2020, 5:13 PM
Closed by commit rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController".

Revision Contents
Changeset List

Diff 50549

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionInlineCommentPreviewController.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentPreviewController.php

Loading...
Phabricator · Built by Phacility