Differential D21218

When a user submits "isEditing" inlines and chooses to publish them, publish their current draft state as-shown
ClosedPublic
Actions

Authored by epriestley on May 4 2020, 8:46 PM.

Tags

None

Referenced Files

	F22552768: D21218.diff
	Wed, Sep 23, 8:37 AM

	Unknown Object (File)
	Jul 11 2026, 4:03 PM

	Unknown Object (File)
	Jul 2 2026, 11:27 AM

	Unknown Object (File)
	Jul 2 2026, 11:27 AM

	Unknown Object (File)
	Jul 2 2026, 11:27 AM

	Unknown Object (File)
	Jul 2 2026, 11:27 AM

	Unknown Object (File)
	Jun 20 2026, 4:20 AM

	Unknown Object (File)
	Jun 10 2026, 10:38 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rP7fa47408a3c5: When a user submits "isEditing" inlines and chooses to publish them, publish…

Summary

Ref T13513. When users choose to publish inlines, we want to publish the visible text, not the last "checkpointed" state.

Test Plan

Created an inline ("AAA").
Edited it into "BBB", did not save.
Submitted.
Confirmed that I want to publish the unsaved inline.
Saw "BBB" publish.

Diff Detail

Repository

Branch

focus2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24348
Build 33542: Run Core Tests
Build 33541: arc lint + arc unit

Event Timeline

epriestley created this revision.May 4 2020, 8:46 PM

Harbormaster completed remote builds in B24348: Diff 50531.May 4 2020, 8:47 PM

epriestley requested review of this revision.May 4 2020, 8:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 10:16 PM

Closed by commit rP7fa47408a3c5: When a user submits "isEditing" inlines and chooses to publish them, publish… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7fa47408a3c5: When a user submits "isEditing" inlines and chooses to publish them, publish….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialTransactionQuery.php

11 lines

Diff 50531

src/applications/differential/query/DifferentialTransactionQuery.php

Loading...