Page MenuHomePhabricator

Fix an issue where text intradiff bodies may not render
ClosedPublic

Authored by epriestley on May 4 2020, 2:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 5:49 PM
Unknown Object (File)
Feb 22 2024, 1:11 AM
Unknown Object (File)
Feb 5 2024, 5:23 AM
Unknown Object (File)
Jan 19 2024, 4:41 PM
Unknown Object (File)
Jan 15 2024, 4:03 PM
Unknown Object (File)
Jan 12 2024, 9:52 AM
Unknown Object (File)
Jan 7 2024, 5:30 PM
Unknown Object (File)
Jan 3 2024, 6:30 PM
Subscribers
None

Details

Summary

Ref T13523. In the caching layer, there's a tricky clause about filetypes that skips some body rendering behavior.

Provide file type information which at least has a better chance of representing all changes (e.g., an image file may be replaced with a text file, but this can not be represented by a single file type).

Formalize "hasSourceTextBody()", to mean the changeset parser should engage the change as source text.

Test Plan

Intradiffed text changes, saw the body render properly.

Diff Detail

Repository
rP Phabricator
Branch
idiff1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/parser/DifferentialChangesetParser.php:598XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24326
Build 33512: Run Core Tests
Build 33511: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 2:40 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.