Fix an issue where text intradiff bodies may not render
ClosedPublic
Actions

Authored by epriestley on May 4 2020, 2:39 PM.

Details

Reviewers: None
Maniphest Tasks: T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes
Commits: rPaa3b447bb0c8: (stable) Fix an issue where text intradiff bodies may not render
rP17426a60f00a: Fix an issue where text intradiff bodies may not render

Summary

Ref T13523. In the caching layer, there's a tricky clause about filetypes that skips some body rendering behavior.

Provide file type information which at least has a better chance of representing all changes (e.g., an image file may be replaced with a text file, but this can not be represented by a single file type).

Formalize "hasSourceTextBody()", to mean the changeset parser should engage the change as source text.

Test Plan

Intradiffed text changes, saw the body render properly.

Diff Detail

Repository

rP Phabricator

Branch

idiff1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/parser/DifferentialChangesetParser.php:598	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24326
Build 33512: Run Core Tests
Build 33511: arc lint + arc unit

Event Timeline

epriestley created this revision.May 4 2020, 2:39 PM

Harbormaster completed remote builds in B24326: Diff 50509.May 4 2020, 2:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 2:40 PM

epriestley requested review of this revision.

Closed by commit rP17426a60f00a: Fix an issue where text intradiff bodies may not render (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP17426a60f00a: Fix an issue where text intradiff bodies may not render.

epriestley added a commit: rPaa3b447bb0c8: (stable) Fix an issue where text intradiff bodies may not render.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

28 lines

storage/

DifferentialChangeset.php

49 lines

Diff 50509

View Options

src/applications/differential/parser/DifferentialChangesetParser.php