session"
ClosedPublic
Actions

Authored by epriestley on Apr 25 2020, 9:00 PM.

Details

Reviewers: None
Maniphest Tasks: T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rP394a109136ef: (stable) Use "rest/api/3/myself" to retrieve JIRA profile details, not…
rPa226d7413383: Use "rest/api/3/myself" to retrieve JIRA profile details, not…

Summary

Ref T13493. At time of writing, the old API method no longer functions: 1/session does not return an accountId but all calls now require one.

Use the modern 3/myself API instead. The datastructure returned by 2/user (older appraoch) and 3/myself (newer approach) is more or less the same, as far as I can tell.

Test Plan

Linked an account against modern-at-time-of-writing Atlassian-hosted JIRA.

Diff Detail

Repository

rP Phabricator

Branch

jira1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24226
Build 33367: Run Core Tests
Build 33366: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 25 2020, 9:00 PM

Harbormaster completed remote builds in B24226: Diff 50407.Apr 25 2020, 9:02 PM

epriestley requested review of this revision.Apr 25 2020, 9:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2020, 9:05 PM

Closed by commit rPa226d7413383: Use "rest/api/3/myself" to retrieve JIRA profile details, not… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa226d7413383: Use "rest/api/3/myself" to retrieve JIRA profile details, not….

epriestley added a commit: rP394a109136ef: (stable) Use "rest/api/3/myself" to retrieve JIRA profile details, not….

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

adapter/

PhutilJIRAAuthAdapter.php

34 lines

Diff 50407

View Options

src/applications/auth/adapter/PhutilJIRAAuthAdapter.php

Use "rest/api/3/myself" to retrieve JIRA profile details, not "rest/auth/1/session"ClosedPublicActions