Page MenuHomePhabricator

When proxying HTTP repository responses from repository nodes, discard content description headers
ClosedPublic

Authored by epriestley on Apr 25 2020, 2:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 2:54 PM
Unknown Object (File)
Wed, Apr 24, 10:50 PM
Unknown Object (File)
Apr 1 2024, 11:18 PM
Unknown Object (File)
Mar 29 2024, 2:54 PM
Unknown Object (File)
Jan 22 2024, 4:20 PM
Unknown Object (File)
Jan 16 2024, 4:16 PM
Unknown Object (File)
Dec 30 2023, 5:16 PM
Unknown Object (File)
Dec 26 2023, 6:36 PM
Subscribers
None

Details

Summary

Ref T13517. See that task for details about the underlying issue here.

Currently, we may decode a compressed response, then retransmit it with leftover "Content-Encoding" and "Content-Length" headers. Instead, strip these headers.

Test Plan
  • In a clustered repository setup, cloned a Git repository over HTTP.
  • Before: Error while processing content unencoding: invalid stored block lengths
  • After: Clean clone.

Diff Detail

Repository
rP Phabricator
Branch
http1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24217
Build 33355: Run Core Tests
Build 33354: arc lint + arc unit