Page MenuHomePhabricator

When proxying HTTP repository responses from repository nodes, discard content description headers
ClosedPublic

Authored by epriestley on Apr 25 2020, 2:40 PM.
Tags
None
Referenced Files
F18636122: D21167.diff
Wed, Sep 17, 3:33 AM
F18519437: D21167.diff
Fri, Sep 5, 4:57 PM
F18166210: D21167.id50398.diff
Aug 15 2025, 9:53 AM
F18092515: D21167.id50399.diff
Aug 7 2025, 11:02 AM
F18089321: D21167.id.diff
Aug 6 2025, 11:10 AM
F18082789: D21167.diff
Aug 5 2025, 7:28 AM
F18078178: D21167.id50399.diff
Aug 4 2025, 7:54 PM
F18077684: D21167.id50398.diff
Aug 4 2025, 7:23 PM
Subscribers
None

Details

Summary

Ref T13517. See that task for details about the underlying issue here.

Currently, we may decode a compressed response, then retransmit it with leftover "Content-Encoding" and "Content-Length" headers. Instead, strip these headers.

Test Plan
  • In a clustered repository setup, cloned a Git repository over HTTP.
  • Before: Error while processing content unencoding: invalid stored block lengths
  • After: Clean clone.

Diff Detail

Repository
rP Phabricator
Branch
http1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24217
Build 33355: Run Core Tests
Build 33354: arc lint + arc unit