Page MenuHomePhabricator

Don't pass "No newline at end of file." annotations to DocumentEngines as literal diff text
ClosedPublic

Authored by epriestley on Apr 23 2020, 3:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 5, 4:51 PM
Unknown Object (File)
Wed, May 28, 5:08 PM
Unknown Object (File)
May 5 2025, 8:07 PM
Unknown Object (File)
Apr 30 2025, 12:28 PM
Unknown Object (File)
Apr 29 2025, 4:30 AM
Unknown Object (File)
Apr 28 2025, 11:12 AM
Unknown Object (File)
Apr 24 2025, 9:42 PM
Unknown Object (File)
Mar 30 2025, 11:02 PM
Subscribers
None

Details

Summary

See PHI1707, which has a Jupyter notebook which fails to diff nicely when modified. The root cause seems to be that the document does not end in a newline.

Test Plan

Applied patch, diffed the file, got a Jupyter diff out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable