Page MenuHomePhabricator

Don't pass "No newline at end of file." annotations to DocumentEngines as literal diff text
ClosedPublic

Authored by epriestley on Apr 23 2020, 3:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 4:56 PM
Unknown Object (File)
Sat, Jan 25, 7:17 AM
Unknown Object (File)
Sat, Jan 25, 7:17 AM
Unknown Object (File)
Sat, Jan 25, 7:17 AM
Unknown Object (File)
Sat, Jan 25, 7:17 AM
Unknown Object (File)
Sat, Jan 25, 4:47 AM
Unknown Object (File)
Thu, Jan 23, 7:27 AM
Unknown Object (File)
Tue, Jan 21, 10:29 AM
Subscribers
None

Details

Summary

See PHI1707, which has a Jupyter notebook which fails to diff nicely when modified. The root cause seems to be that the document does not end in a newline.

Test Plan

Applied patch, diffed the file, got a Jupyter diff out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable