Don't pass "No newline at end of file." annotations to DocumentEngines as literal diff text
ClosedPublic
Actions

Authored by epriestley on Apr 23 2020, 3:21 AM.

Details

Reviewers: None
Commits: rP1d9d2d066e22: (stable) Don't pass "No newline at end of file." annotations to DocumentEngines…
rPbefbea2f00e6: Don't pass "No newline at end of file." annotations to DocumentEngines as…

Summary

See PHI1707, which has a Jupyter notebook which fails to diff nicely when modified. The root cause seems to be that the document does not end in a newline.

Test Plan

Applied patch, diffed the file, got a Jupyter diff out of it.

Diff Detail

Repository

rP Phabricator

Branch

docengine1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24195
Build 33325: Run Core Tests
Build 33324: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 23 2020, 3:21 AM

Harbormaster completed remote builds in B24195: Diff 50377.Apr 23 2020, 3:22 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 23 2020, 3:22 AM

epriestley requested review of this revision.

Closed by commit rPbefbea2f00e6: Don't pass "No newline at end of file." annotations to DocumentEngines as… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPbefbea2f00e6: Don't pass "No newline at end of file." annotations to DocumentEngines as….

epriestley added a commit: rP1d9d2d066e22: (stable) Don't pass "No newline at end of file." annotations to DocumentEngines….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

26 lines

Diff 50377

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Don't pass "No newline at end of file." annotations to DocumentEngines as literal diff textClosedPublicActions