Page MenuHomePhabricator

Don't pass "No newline at end of file." annotations to DocumentEngines as literal diff text
ClosedPublic

Authored by epriestley on Apr 23 2020, 3:21 AM.

Details

Summary

See PHI1707, which has a Jupyter notebook which fails to diff nicely when modified. The root cause seems to be that the document does not end in a newline.

Test Plan

Applied patch, diffed the file, got a Jupyter diff out of it.

Diff Detail

Repository
rP Phabricator
Branch
docengine1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24195
Build 33325: Run Core Tests
Build 33324: arc lint + arc unit