Page MenuHomePhabricator
Differential D21128

Combine the two different ngram-splitting algorithms into a single engine
ClosedPublic
Actions

Authored by epriestley on Apr 16 2020, 4:38 PM.
Tags
None
Referenced Files
F18755645: D21128.id.diff
Sun, Oct 5, 6:43 AM
F18751806: D21128.diff
Sat, Oct 4, 12:43 PM
F18739411: D21128.id.diff
Wed, Oct 1, 9:19 PM
F18734235: D21128.id.diff
Tue, Sep 30, 10:50 PM
F18701857: D21128.diff
Sat, Sep 27, 9:31 PM
F18699307: D21128.id50313.diff
Sat, Sep 27, 12:40 PM
F18697767: D21128.id.diff
Sat, Sep 27, 10:05 AM
F18686648: D21128.id50317.diff
Fri, Sep 26, 1:12 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13501: Improve search index normalization of "é" and other characters with variants or multiple representations
Commits
rP9bdf477f2fef: Combine the two different ngram-splitting algorithms into a single engine
Summary

Ref T13501. Depends on D21127. With the "prefix" behavior removed in D21127, we now have two virtually identical copies of the same code.

The newer one in Ferret is better: it slices utf8 correctly and is slightly more efficient on large inputs. Pull it out and make all callers call into it.

Test Plan
  • Grepped for all affected symbols.
  • Ran bin/search index --force ... to reindex various objects (tasks, files).
  • Searched for things in the UI.

Diff Detail

Repository
rP Phabricator
Branch
search3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24131
Build 33228: Run Core Tests
Build 33227: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 16 2020, 4:38 PM
Harbormaster completed remote builds in B24131: Diff 50313.Apr 16 2020, 4:39 PM
epriestley requested review of this revision.Apr 16 2020, 4:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 16 2020, 4:45 PM
Closed by commit rP9bdf477f2fef: Combine the two different ngram-splitting algorithms into a single engine (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP9bdf477f2fef: Combine the two different ngram-splitting algorithms into a single engine.

Revision Contents
Changeset List

Diff 50313

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/search/engine/PhabricatorSearchNgramEngine.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php

Loading...
View Options

src/applications/search/ferret/PhabricatorFerretEngine.php

Loading...
View Options

src/applications/search/ferret/__tests__/PhabricatorFerretEngineTestCase.php

Loading...
View Options

src/applications/search/ngrams/PhabricatorSearchNgrams.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility