Remove unused "getAllFunctionFields()" from Ferret
ClosedPublic
Actions

Authored by epriestley on Apr 16 2020, 3:05 PM.

Tags

None

Referenced Files

	F18208991: D21126.id50315.diff
	Mon, Aug 18, 10:11 PM

	F18196150: D21126.id.diff
	Sun, Aug 17, 5:08 PM

	F18187349: D21126.diff
	Sat, Aug 16, 7:39 PM

	Unknown Object (File)
	Jun 6 2025, 3:45 PM

	Unknown Object (File)
	May 10 2025, 1:21 PM

	Unknown Object (File)
	May 5 2025, 9:19 PM

	Unknown Object (File)
	Apr 21 2025, 8:34 PM

	Unknown Object (File)
	Apr 11 2025, 8:58 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13511: Allow extensions to define new document fields (like "title:") in Ferret search
Commits: rPb1b9c844ac1a: Remove unused "getAllFunctionFields()" from Ferret

Summary

Ref T13511. This function does nothing interesting and has no callers.

Test Plan

Grepped for callers.

Diff Detail

Repository

rP Phabricator

Branch

search1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24129
Build 33224: Run Core Tests
Build 33223: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 16 2020, 3:05 PM

Harbormaster completed remote builds in B24129: Diff 50311.Apr 16 2020, 3:07 PM

epriestley requested review of this revision.Apr 16 2020, 3:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 16 2020, 4:43 PM

Closed by commit rPb1b9c844ac1a: Remove unused "getAllFunctionFields()" from Ferret (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb1b9c844ac1a: Remove unused "getAllFunctionFields()" from Ferret.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

ferret/

PhabricatorFerretEngine.php

11 lines

Diff 50311

View Options

src/applications/search/ferret/PhabricatorFerretEngine.php

Remove unused "getAllFunctionFields()" from FerretClosedPublicActions