Page MenuHomePhabricator

Reduce the verbosity of the "Aphlict" log
ClosedPublic

Authored by epriestley on Apr 14 2020, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 1:16 AM
Unknown Object (File)
Tue, Nov 19, 2:49 PM
Unknown Object (File)
Fri, Nov 15, 7:56 AM
Unknown Object (File)
Sun, Nov 10, 10:33 PM
Unknown Object (File)
Wed, Nov 6, 10:49 PM
Unknown Object (File)
Oct 17 2024, 9:46 PM
Unknown Object (File)
Oct 9 2024, 1:20 PM
Unknown Object (File)
Oct 9 2024, 1:20 PM
Subscribers
None

Details

Summary

See PHI1692. Currently, the Aphlict log is ridiculously verbose. As an initial pass at improving this:

  • When starting in "debug" mode, pass "--debug=1" to Node.
  • In Node, separate logging into "log" (lower-volume, more-important messages) and "trace" (higher-volume, less-important messages).
  • Only print "trace" messages in "debug" mode.
Test Plan

Ran Aphlict in debug and non-debug modes. Behavior unchanged in debug mode, but log has more sensible verbosity in non-debug mode.

Diff Detail

Repository
rP Phabricator
Branch
node1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24104
Build 33188: Run Core Tests
Build 33187: arc lint + arc unit