Differential D21110

Implement the "present" and "absent" operators in the Ferret execution engine
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 5:22 PM.

Details

Reviewers: None
Maniphest Tasks: T13509: Support "field present" and "field absent" operators in Ferret
Commits: rP0511b2a0129e: Implement the "present" and "absent" operators in the Ferret execution engine

Summary

Ref T13509. Now that the compiler can parse these queries, actually implement them.

These are fairly easy to implement:

For present, just "JOIN". If it works, the field is present.
For absent, we "LEFT JOIN" and then "WHERE any_column IS NULL".

Test Plan

Searched for various documents with and without fields present, got sensible results in Maniphest. For example, "body:-" finds tasks with no body, "body:- duck" finds tasks with no body and "duck" elsewhere in the content, and so on.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2020, 5:22 PM

Harbormaster completed remote builds in B24092: Diff 50274.Apr 14 2020, 5:23 PM

epriestley requested review of this revision.Apr 14 2020, 5:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 5:55 PM

Closed by commit rP0511b2a0129e: Implement the "present" and "absent" operators in the Ferret execution engine (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0511b2a0129e: Implement the "present" and "absent" operators in the Ferret execution engine.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

60 lines

Diff 50281

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Implement the "present" and "absent" operators in the Ferret execution engineClosedPublicActions