Page MenuHomePhabricator
Differential D21050

Fix error behavior of "arc version" when it encounters a library which is not a working copy
ClosedPublic
Actions

Authored by epriestley on Apr 2 2020, 3:20 PM.
Tags
None
Referenced Files
F18777823: D21050.id50150.diff
Sat, Oct 11, 5:43 AM
F18734180: D21050.id.diff
Tue, Sep 30, 10:49 PM
F18600618: D21050.diff
Sat, Sep 13, 10:08 AM
F18567702: D21050.id.diff
Sep 9 2025, 4:06 PM
F18446228: D21050.id.diff
Aug 31 2025, 9:13 PM
F18420208: D21050.diff
Aug 30 2025, 4:02 PM
F18394871: D21050.id50151.diff
Aug 29 2025, 10:33 AM
F18392507: D21050.id50150.diff
Aug 29 2025, 8:20 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable
Commits
rARC5ce1d7971746: Fix error behavior of "arc version" when it encounters a library which is not a…
Summary

Ref T13504. The API has changed here slightly, and if you run "arc version" without "arcanist/" being a Git working copy, it currently fatals in a misleading way.

Instead, reach the error properly.

Test Plan

Ran "arc version" after moving aside ".git/", got a helpful error message instead of a confusing "call on null" exception.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
toolset/
workflow/
18 lines

Diff 50151

View Options

src/toolset/workflow/ArcanistVersionWorkflow.php

Loading...
Phabricator · Built by Phacility