Page MenuHomePhabricator
Differential D21050

Fix error behavior of "arc version" when it encounters a library which is not a working copy
ClosedPublic
Actions

Authored by epriestley on Apr 2 2020, 3:20 PM.
Tags
None
Referenced Files
F15519000: D21050.id50151.diff
Sat, Apr 19, 6:52 PM
F15518133: D21050.diff
Sat, Apr 19, 11:14 AM
F15490066: D21050.diff
Fri, Apr 11, 2:04 PM
F15467582: D21050.id50151.diff
Apr 3 2025, 4:28 PM
F15464995: D21050.id50151.diff
Apr 2 2025, 1:30 PM
F15463437: D21050.id.diff
Apr 1 2025, 11:30 PM
F15462402: D21050.id50150.diff
Apr 1 2025, 2:54 PM
F15440164: D21050.id50151.diff
Mar 26 2025, 11:18 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable
Commits
rARC5ce1d7971746: Fix error behavior of "arc version" when it encounters a library which is not a…
Summary

Ref T13504. The API has changed here slightly, and if you run "arc version" without "arcanist/" being a Git working copy, it currently fatals in a misleading way.

Instead, reach the error properly.

Test Plan

Ran "arc version" after moving aside ".git/", got a helpful error message instead of a confusing "call on null" exception.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
toolset/
workflow/
18 lines

Diff 50151

View Options

src/toolset/workflow/ArcanistVersionWorkflow.php

Loading...
Phabricator · Built by Phacility