Page MenuHomePhabricator

Fix error behavior of "arc version" when it encounters a library which is not a working copy
ClosedPublic

Authored by epriestley on Apr 2 2020, 3:20 PM.
Tags
None
Referenced Files
F19192193: D21050.id50150.diff
Dec 16 2025, 10:13 AM
F19139469: D21050.id50151.diff
Dec 10 2025, 11:46 AM
F19138941: D21050.id50151.diff
Dec 10 2025, 11:18 AM
F19099791: D21050.id.diff
Dec 4 2025, 9:14 PM
F19091848: D21050.diff
Dec 3 2025, 3:33 PM
F19083207: D21050.id50151.diff
Dec 2 2025, 12:32 PM
F19039893: D21050.diff
Nov 26 2025, 10:08 AM
F18985374: D21050.id50150.diff
Nov 17 2025, 1:00 PM
Subscribers
None

Details

Summary

Ref T13504. The API has changed here slightly, and if you run "arc version" without "arcanist/" being a Git working copy, it currently fatals in a misleading way.

Instead, reach the error properly.

Test Plan

Ran "arc version" after moving aside ".git/", got a helpful error message instead of a confusing "call on null" exception.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable