Page MenuHomePhabricator

Fix three Windows subprocess issues
ClosedPublic

Authored by epriestley on Apr 1 2020, 11:06 PM.
Tags
None
Referenced Files
F14078536: D21047.diff
Fri, Nov 22, 4:11 AM
Unknown Object (File)
Sat, Oct 26, 10:40 PM
Unknown Object (File)
Oct 17 2024, 7:44 AM
Unknown Object (File)
Sep 30 2024, 8:03 PM
Unknown Object (File)
Sep 30 2024, 12:35 PM
Unknown Object (File)
Sep 30 2024, 5:56 AM
Unknown Object (File)
Sep 24 2024, 10:47 AM
Unknown Object (File)
Sep 6 2024, 7:13 AM
Subscribers
None

Details

Summary

Fixes T13504. This fixes three issues:

  1. In ExecFuture, "proc_open()" on an invalid binary could fail with an unconditional exception.
  2. In ExecPassthru, "proc_open()" on an invalid binary could fail with an unconditional exception.
  3. In "arc browse", "start <url>" does not work when the shell is bypassed.

In (1) and (2), the desired behavior is to fail with an exit code which is sometimes upgraded to an exception depending on calling convention.

Issue (1) most commonly manifested as "find" failing when run via "cmd.exe".

Issue (2) most commonly manifested as "arc browse" failing.

Issue (3) was entangled with issue (2).

In cases (1) and (2), assume "proc_open()" failures under Windows are because of bad binaries and treat them like bogus commands on Linux/Mac.

In case (3), use "cmd /c start" instead of "start" as a default browser on Windows.

Test Plan
  • On Windows, did mime type detection in cmd.exe. Before patch: proc_open() exception in "find". After patch: clean (albeit not terribly useful) detection.
  • On Windows, did "arc browse ...". Before patch: proc_open() exception in "start". After patch: clean browser execution.

Diff Detail

Repository
rARC Arcanist
Branch
win1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23965
Build 32978: Run Core Tests
Build 32977: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2020, 11:11 PM
This revision was automatically updated to reflect the committed changes.