Page MenuHomePhabricator

Fix an issue where "arc" may fail on startup when trying to read older "default" config
ClosedPublic

Authored by epriestley on Mar 6 2020, 3:22 PM.
Tags
None
Referenced Files
F19512315: D21039.id50111.diff
Mon, Jan 12, 4:26 PM
F19510712: D21039.id.diff
Sun, Jan 11, 1:45 PM
F19510528: D21039.id50112.diff
Sun, Jan 11, 11:17 AM
F19509742: D21039.diff
Sun, Jan 11, 12:35 AM
F19509606: D21039.diff
Sat, Jan 10, 10:52 PM
F19083193: D21039.id50112.diff
Dec 2 2025, 12:32 PM
F19059245: D21039.id50112.diff
Nov 29 2025, 4:55 AM
F19054823: D21039.id50112.diff
Nov 28 2025, 2:44 PM
Subscribers
None

Details

Summary

See PHI1663. If "phabricator.uri" is not configured, we try to fall back to "default", but doesn't have a modern config specification and fails.

Instead, read "default" as a raw config value to preserve compatible behavior. My intent is to eventually remove it.

Test Plan

In a directory with no "phabricator.uri" config available, ran echo {} | arc call-conduit conduit.ping. After the patch, got a reasonable error instead of a fatal.

In a directory with "default" configured but not "phabricator.uri", ran the same command. After the patch, got a ping.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable