Page MenuHomePhabricator

Fix an issue where "arc" may fail on startup when trying to read older "default" config
ClosedPublic

Authored by epriestley on Mar 6 2020, 3:22 PM.
Tags
None
Referenced Files
F13051824: D21039.diff
Fri, Apr 19, 4:53 AM
Unknown Object (File)
Sun, Mar 31, 6:56 PM
Unknown Object (File)
Mar 14 2024, 6:07 PM
Unknown Object (File)
Feb 15 2024, 6:03 AM
Unknown Object (File)
Feb 13 2024, 5:55 AM
Unknown Object (File)
Jan 21 2024, 4:47 PM
Unknown Object (File)
Jan 18 2024, 2:59 PM
Unknown Object (File)
Jan 7 2024, 4:15 PM
Subscribers
None

Details

Summary

See PHI1663. If "phabricator.uri" is not configured, we try to fall back to "default", but doesn't have a modern config specification and fails.

Instead, read "default" as a raw config value to preserve compatible behavior. My intent is to eventually remove it.

Test Plan

In a directory with no "phabricator.uri" config available, ran echo {} | arc call-conduit conduit.ping. After the patch, got a reasonable error instead of a fatal.

In a directory with "default" configured but not "phabricator.uri", ran the same command. After the patch, got a ping.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable