Page MenuHomePhabricator

Fix an issue where "arc" may fail on startup when trying to read older "default" config
ClosedPublic

Authored by epriestley on Mar 6 2020, 3:22 PM.
Tags
None
Referenced Files
F18831528: D21039.id.diff
Sat, Oct 25, 1:38 PM
F18829737: D21039.diff
Sat, Oct 25, 12:40 AM
F18818520: D21039.id.diff
Wed, Oct 22, 12:41 AM
F18784936: D21039.id50112.diff
Mon, Oct 13, 3:52 PM
F18784934: D21039.id50111.diff
Mon, Oct 13, 3:52 PM
F18783729: D21039.diff
Mon, Oct 13, 9:10 AM
F18746326: D21039.id50111.diff
Oct 3 2025, 12:09 PM
F18734175: D21039.id.diff
Sep 30 2025, 10:49 PM
Subscribers
None

Details

Summary

See PHI1663. If "phabricator.uri" is not configured, we try to fall back to "default", but doesn't have a modern config specification and fails.

Instead, read "default" as a raw config value to preserve compatible behavior. My intent is to eventually remove it.

Test Plan

In a directory with no "phabricator.uri" config available, ran echo {} | arc call-conduit conduit.ping. After the patch, got a reasonable error instead of a fatal.

In a directory with "default" configured but not "phabricator.uri", ran the same command. After the patch, got a ping.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable