Page MenuHomePhabricator

Fix an issue where "arc" may fail on startup when trying to read older "default" config
ClosedPublic

Authored by epriestley on Mar 6 2020, 3:22 PM.

Details

Summary

See PHI1663. If "phabricator.uri" is not configured, we try to fall back to "default", but doesn't have a modern config specification and fails.

Instead, read "default" as a raw config value to preserve compatible behavior. My intent is to eventually remove it.

Test Plan

In a directory with no "phabricator.uri" config available, ran echo {} | arc call-conduit conduit.ping. After the patch, got a reasonable error instead of a fatal.

In a directory with "default" configured but not "phabricator.uri", ran the same command. After the patch, got a ping.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 6 2020, 3:22 PM
epriestley requested review of this revision.Mar 6 2020, 3:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 6 2020, 4:31 PM
This revision was automatically updated to reflect the committed changes.