Page MenuHomePhabricator

Fix an issue where "arc" may fail on startup when trying to read older "default" config
ClosedPublic

Authored by epriestley on Mar 6 2020, 3:22 PM.
Tags
None
Referenced Files
F22721562: D21039.id50112.diff
Sat, Oct 3, 10:29 PM
F22638310: D21039.diff
Wed, Sep 30, 9:27 AM
Unknown Object (File)
Wed, Sep 9, 7:24 PM
Unknown Object (File)
Aug 25 2026, 9:43 PM
Unknown Object (File)
Jul 3 2026, 3:24 PM
Unknown Object (File)
Jul 1 2026, 11:38 AM
Unknown Object (File)
Jun 20 2026, 3:50 AM
Unknown Object (File)
Jun 18 2026, 3:31 AM
Subscribers
None

Details

Summary

See PHI1663. If "phabricator.uri" is not configured, we try to fall back to "default", but doesn't have a modern config specification and fails.

Instead, read "default" as a raw config value to preserve compatible behavior. My intent is to eventually remove it.

Test Plan

In a directory with no "phabricator.uri" config available, ran echo {} | arc call-conduit conduit.ping. After the patch, got a reasonable error instead of a fatal.

In a directory with "default" configured but not "phabricator.uri", ran the same command. After the patch, got a ping.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable