Page MenuHomePhabricator

Fix an issue where "arc" may fail on startup when trying to read older "default" config
ClosedPublic

Authored by epriestley on Mar 6 2020, 3:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 3:51 PM
Unknown Object (File)
Wed, Dec 18, 1:59 PM
Unknown Object (File)
Fri, Dec 13, 12:47 PM
Unknown Object (File)
Nov 6 2024, 2:30 AM
Unknown Object (File)
Oct 23 2024, 3:37 AM
Unknown Object (File)
Oct 22 2024, 6:41 PM
Unknown Object (File)
Oct 14 2024, 3:31 AM
Unknown Object (File)
Oct 2 2024, 6:12 AM
Subscribers
None

Details

Summary

See PHI1663. If "phabricator.uri" is not configured, we try to fall back to "default", but doesn't have a modern config specification and fails.

Instead, read "default" as a raw config value to preserve compatible behavior. My intent is to eventually remove it.

Test Plan

In a directory with no "phabricator.uri" config available, ran echo {} | arc call-conduit conduit.ping. After the patch, got a reasonable error instead of a fatal.

In a directory with "default" configured but not "phabricator.uri", ran the same command. After the patch, got a ping.

Diff Detail

Repository
rARC Arcanist
Branch
default1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23932
Build 32938: Run Core Tests
Build 32937: arc lint + arc unit