Page MenuHomePhabricator

Read both email addresses and Google Account IDs from Google OAuth
ClosedPublic

Authored by epriestley on Feb 24 2020, 9:23 PM.
Tags
None
Referenced Files
F13238880: D21028.diff
Tue, May 21, 10:21 PM
F13233601: D21028.id50094.diff
Tue, May 21, 2:26 AM
F13230697: D21028.diff
Mon, May 20, 11:15 PM
F13225232: D21028.id50093.diff
Sun, May 19, 2:07 PM
F13215801: D21028.id50094.diff
Fri, May 17, 7:55 PM
F13210364: D21028.diff
Fri, May 17, 4:45 AM
F13194267: D21028.diff
Sun, May 12, 9:27 PM
F13183543: D21028.diff
Fri, May 10, 10:16 AM
Subscribers
None

Details

Summary

Ref T13493. Google returns a lower-quality account identifier ("email") and a higher-quality account identifier ("id"). We currently read only "email".

Change the logic to read both "email" and "id", so that if Google ever moves away from "email" the transition will be a bit easier.

Test Plan

Linked/unlinked a Google account, looked at the external account identifier table.

Diff Detail

Repository
rP Phabricator
Branch
gauth1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23915
Build 32908: Run Core Tests
Build 32907: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 9:26 PM
This revision was automatically updated to reflect the committed changes.