Read both email addresses and Google Account IDs from Google OAuth
ClosedPublic
Actions

Authored by epriestley on Feb 24 2020, 9:23 PM.

Details

Reviewers: None
Maniphest Tasks: T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rPd0f4554dbeb0: Read both email addresses and Google Account IDs from Google OAuth

Summary

Ref T13493. Google returns a lower-quality account identifier ("email") and a higher-quality account identifier ("id"). We currently read only "email".

Change the logic to read both "email" and "id", so that if Google ever moves away from "email" the transition will be a bit easier.

Test Plan

Linked/unlinked a Google account, looked at the external account identifier table.

Diff Detail

Repository

rP Phabricator

Branch

gauth1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23915
Build 32908: Run Core Tests
Build 32907: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 24 2020, 9:23 PM

Harbormaster completed remote builds in B23915: Diff 50093.Feb 24 2020, 9:24 PM

epriestley requested review of this revision.Feb 24 2020, 9:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 9:26 PM

Closed by commit rPd0f4554dbeb0: Read both email addresses and Google Account IDs from Google OAuth (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd0f4554dbeb0: Read both email addresses and Google Account IDs from Google OAuth.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

adapter/

PhutilGoogleAuthAdapter.php

19 lines

provider/

PhabricatorAuthProvider.php

7 lines

Diff 50093

View Options

src/applications/auth/adapter/PhutilGoogleAuthAdapter.php