Page MenuHomePhabricator

Add an "ExternalAccountIdentifier" table
ClosedPublic

Authored by epriestley on Feb 20 2020, 10:21 PM.

Details

Summary

Depends on D21010. Ref T13493. External accounts may have multiple different unique identifiers, most often when v1 of the API makes a questionable choice (and provies a mutable, non-unique, or PII identifier) and v2 of the API uses an immutable, unique, random identifier.

Allow Phabricator to store multiple identifiers per external account.

Test Plan

Storage only, see followup changes.

Diff Detail

Repository
rP Phabricator
Branch
auth3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/people/storage/PhabricatorExternalAccountIdentifier.php:48XHP16TODO Comment
Unit
Test Failures
Build Status
Buildable 23879
Build 32854: Run Core Tests
Build 32853: arc lint + arc unit

Unit TestsFailed

TimeTest
59 msConpherenceRoomTestCase::testNUserRoomCreate
EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
18 msConpherenceRoomTestCase::testOneUserRoomCreate
EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
52 msConpherenceRoomTestCase::testRoomParticipantAddition
EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
52 msConpherenceRoomTestCase::testRoomParticipantDeletion
EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
17 msHarbormasterAutotargetsTestCase::testGenerateHarbormasterAutotargets
EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
View Full Test Results (98 Failed · 335 Passed · 2 Skipped)

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 20 2020, 10:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:44 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.