Add an "ExternalAccountIdentifier" table
ClosedPublic
Actions

Authored by epriestley on Feb 20 2020, 10:21 PM.

Details

Reviewers: None
Maniphest Tasks: T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rP70845a2d13fc: Add an "ExternalAccountIdentifier" table

Summary

Depends on D21010. Ref T13493. External accounts may have multiple different unique identifiers, most often when v1 of the API makes a questionable choice (and provies a mutable, non-unique, or PII identifier) and v2 of the API uses an immutable, unique, random identifier.

Allow Phabricator to store multiple identifiers per external account.

Test Plan

Storage only, see followup changes.

Diff Detail

Repository

rP Phabricator

Branch

auth3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/people/storage/PhabricatorExternalAccountIdentifier.php:48	XHP16	TODO Comment

Unit

Test Failures

Build Status

Buildable 23879
Build 32854: Run Core Tests
Build 32853: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	59 ms	ConpherenceRoomTestCase::testNUserRoomCreate EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
	18 ms	ConpherenceRoomTestCase::testOneUserRoomCreate EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
	52 ms	ConpherenceRoomTestCase::testRoomParticipantAddition EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
	52 ms	ConpherenceRoomTestCase::testRoomParticipantDeletion EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
	17 ms	HarbormasterAutotargetsTestCase::testGenerateHarbormasterAutotargets EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-83/repo/phabricator/src/applications/people/phid/PhabricatorPeopleExternalIdentiferPHIDType.php" failed to load. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/pe...')
		View Full Test Results (98 Failed · 335 Passed · 2 Skipped)