Stop exposing raw "accountID" values directly in the web UI
ClosedPublic
Actions

Authored by epriestley on Feb 20 2020, 9:33 PM.

Details

Reviewers: None
Maniphest Tasks: T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rPfbf050167e25: Stop exposing raw "accountID" values directly in the web UI

Summary

Ref T13493. The "AuthAccountView" UI element currently exposes raw account ID values, but I'm trying to make these many-to-one.

This isn't terribly useful as-is, so get rid of it. This element could use a design refresh in general.

Test Plan

Viewed the UI element in "External Accounts".

Diff Detail

Repository

rP Phabricator

Branch

auth2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23878
Build 32852: Run Core Tests
Build 32851: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 20 2020, 9:33 PM

Harbormaster completed remote builds in B23878: Diff 50054.Feb 20 2020, 9:34 PM

epriestley requested review of this revision.Feb 20 2020, 9:34 PM

epriestley added a child revision: D21011: Add an "ExternalAccountIdentifier" table.Feb 20 2020, 10:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:42 AM

Closed by commit rPfbf050167e25: Stop exposing raw "accountID" values directly in the web UI (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPfbf050167e25: Stop exposing raw "accountID" values directly in the web UI.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

view/

PhabricatorAuthAccountView.php

4 lines

Diff 50054

View Options

src/applications/auth/view/PhabricatorAuthAccountView.php

Stop exposing raw "accountID" values directly in the web UIClosedPublicActions