Paths

Table of Contentst

Differential D21009

Whitelist "vscode://" as an allowed Editor protocol
ClosedPublic
Actions

Authored by epriestley on Feb 20 2020, 8:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Feb 12, 12:02 AM

	Unknown Object (File)
	Mon, Jan 27, 11:19 AM

	Unknown Object (File)
	Sun, Jan 26, 6:57 AM

	Unknown Object (File)
	Fri, Jan 24, 8:40 PM

	Unknown Object (File)
	Jan 1 2025, 2:53 PM

	Unknown Object (File)
	Dec 27 2024, 7:19 PM

	Unknown Object (File)
	Dec 21 2024, 12:43 AM

	Unknown Object (File)
	Dec 20 2024, 1:09 PM

Subscribers

None

Details

Reviewers: None
Commits: rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol
rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol

Summary

See PHI1647, which asks for "vscode://" to be a configurable protocol on hosted Phacility instances.

I made the configuration editable in D21008, but this can reasonably just come upstream too.

Test Plan

Viewed config in Config, set my editor URI to vscode://blahblah.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 20 2020, 8:41 PM

Harbormaster completed remote builds in B23875: Diff 50051.Feb 20 2020, 8:43 PM

epriestley requested review of this revision.Feb 20 2020, 8:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 8:45 PM

Closed by commit rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP149155ee20e8: Whitelist "vscode://" as an allowed Editor protocol.

epriestley added a commit: rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol.Apr 5 2020, 4:47 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorSecurityConfigOptions.php

3 lines

Diff 50053

src/applications/config/option/PhabricatorSecurityConfigOptions.php

Loading...