Differential D20985

Merge "--draft" flag and related changes from "experimental" to "master"
ClosedPublic
Actions

Authored by epriestley on Feb 13 2020, 12:36 AM.

Details

Reviewers: None
Maniphest Tasks: T13010: Upgrading: Differential Draft State
Commits: rARC26f853b63430: Merge "--draft" flag and related changes from "experimental" to "master"

Summary

Ref T13010. This brings the "--draft" flag (and a handful of related flags) to "master" from "experimental".

Test Plan

Ran "arc diff". This code has been in use on "experimental" for a long time.

Diff Detail

Repository

rARC Arcanist

Branch

draft1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/workflow/ArcanistDiffWorkflow.php:532	XHP16	TODO Comment
Advice	src/workflow/ArcanistDiffWorkflow.php:602	XHP16	TODO Comment
Advice	src/workflow/ArcanistDiffWorkflow.php:1796	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23829
Build 32777: Run Core Tests
Build 32776: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2020, 12:36 AM

Harbormaster completed remote builds in B23829: Diff 50003.Feb 13 2020, 12:37 AM

epriestley requested review of this revision.Feb 13 2020, 12:37 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 12:54 AM

Closed by commit rARC26f853b63430: Merge "--draft" flag and related changes from "experimental" to "master" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC26f853b63430: Merge "--draft" flag and related changes from "experimental" to "master".

Revision Contents
Changeset List

Path

Size

src/

differential/

ArcanistDifferentialCommitMessage.php

15 lines

workflow/

ArcanistDiffWorkflow.php

202 lines

Diff 50003

View Options

src/differential/ArcanistDifferentialCommitMessage.php