Page MenuHomePhabricator

Fully merge "libphutil/" into "arcanist/"
ClosedPublic

Authored by epriestley on Feb 12 2020, 11:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 9:30 AM
Unknown Object (File)
Sep 14 2024, 6:18 PM
Unknown Object (File)
Sep 14 2024, 4:03 PM
Unknown Object (File)
Sep 6 2024, 7:06 AM
Unknown Object (File)
Sep 6 2024, 7:05 AM
Unknown Object (File)
Sep 6 2024, 7:05 AM
Unknown Object (File)
Sep 6 2024, 7:05 AM
Unknown Object (File)
Sep 4 2024, 11:21 PM
Subscribers
None

Details

Summary

Ref T13395. Moves all remaining code in "libphutil/" into "arcanist/".

Test Plan

Ran various arc workflows, although this probably has some remaining rough edges.

Diff Detail

Repository
rARC Arcanist
Branch
merge1
Lint
Lint Errors
SeverityLocationCodeMessage
Errorresources/ssl/default.pem:1823TXT5Bad Charset
Errorresources/ssl/default.pem:2363TXT5Bad Charset
Errorresources/ssl/default.pem:3758TXT5Bad Charset
Errorresources/ssl/default.pem:3782TXT5Bad Charset
Errorsrc/console/__tests__/wrap/utf8.txt:1TXT5Bad Charset
Errorsrc/console/__tests__/wrap/utf8.txt.expect:1TXT5Bad Charset
Errorsrc/console/__tests__/wrap/utf8.txt.expect:2TXT5Bad Charset
Warningsrc/channel/PhutilSocketChannel.php:86XHP95Self Class Reference
Warningsrc/channel/PhutilSocketChannel.php:87XHP95Self Class Reference
Warningsrc/console/PhutilConsole.php:84XHP95Self Class Reference
Warningsrc/console/PhutilConsole.php:96XHP95Self Class Reference
Warningsrc/console/__tests__/wrap/plain.txt:1SPELL1Possible Spelling Mistake
Warningsrc/console/__tests__/wrap/plain.txt:1SPELL1Possible Spelling Mistake
Warningsrc/console/__tests__/wrap/plain.txt.expect:5SPELL1Possible Spelling Mistake
Warningsrc/console/__tests__/wrap/plain.txt.expect:7SPELL1Possible Spelling Mistake
Warningsrc/events/PhutilEventEngine.php:15XHP95Self Class Reference
Warningsrc/filesystem/PhutilDirectoryFixture.php:17XHP95Self Class Reference
Warningsrc/filesystem/PhutilFileLock.php:43XHP95Self Class Reference
Auto-Fixsrc/console/__tests__/wrap/trailing-space-prompt.txt:1TXT6Trailing Whitespace
Auto-Fixsrc/console/__tests__/wrap/trailing-space-prompt.txt.expect:1TXT6Trailing Whitespace
Advicesrc/channel/PhutilChannel.php:141XHP16TODO Comment
Advicesrc/console/PhutilConsoleMetrics.php:41XHP16TODO Comment
Advicesrc/console/PhutilConsoleServer.php:77XHP16TODO Comment
Advicesrc/filesystem/Filesystem.php:1148XHP62Class Name Literal
Advicesrc/filesystem/Filesystem.php:1159XHP62Class Name Literal
Unit
Test Failures
Build Status
Buildable 23817
Build 32759: Run Core Tests
Build 32758: arc lint + arc unit

Unit TestsFailed

TimeTest
61 msArcanistLibraryTestCase::testLibraryMap
Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: function.phutil_load_library.
66 msArcanistLibraryTestCase::testLibraryMap
Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: function.phutil_load_library.
17 msPhutilDeferredLogTestCase::testManyWriters
Assertion failed, expected values to be equal (at PhutilDeferredLogTestCase.php:116). Expected vs Actual Output Diff --- Old Value
12 msPhutilDeferredLogTestCase::testManyWriters
Assertion failed, expected values to be equal (at PhutilDeferredLogTestCase.php:116). Expected vs Actual Output Diff --- Old Value
28 msPhutilFileLockTestCase::testInProcessHolding
EXCEPTION (Exception): Unable to hold lock in external process! #0 /Users/epriestley/dev/core/lib/arcanist/src/filesystem/__tests__/PhutilFileLockTestCase.php(51): PhutilFileLockTestCase->holdLock(Object(TempFile)) #1 /Users/epriestley/dev/core/lib/arcanist/src/unit/engine/phutil/PhutilTestCase.php(492): PhutilFileLockTestCase->testInProcessHolding()
View Full Test Results (16 Failed · 896 Passed · 67 Skipped)

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2020, 11:07 PM
Harbormaster failed remote builds in B23817: Diff 49991!

This won't build until the harness is updated.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2020, 11:18 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.