Differential D20971

Respect linebreaks in full HTML tables in Remarkup
ClosedPublic
Actions

Authored by epriestley on Feb 6 2020, 10:53 PM.

Tags

None

Referenced Files

	F18894819: D20971.id49969.diff
	Fri, Nov 7, 2:13 PM

	F18888647: D20971.diff
	Fri, Nov 7, 7:33 AM

	F18865309: D20971.diff
	Mon, Nov 3, 11:38 AM

	F18853460: D20971.id.diff
	Fri, Oct 31, 4:42 PM

	F18832942: D20971.id49968.diff
	Sat, Oct 25, 11:53 PM

	F18832531: D20971.id49969.diff
	Sat, Oct 25, 10:04 PM

	F18829125: D20971.diff
	Fri, Oct 24, 7:59 PM

	F18724200: D20971.id.diff
	Sep 30 2025, 3:12 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T5427: Force a line break in a table cell
Commits: rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup

Summary

Fixes T5427. See PHI1630. See also T13160 and D20568.

In the full HTML table syntax with "<table>", respect linebreaks as literals inside "<td>" cells.

Test Plan

Previewed some full-HTML tables with and without linebreaks, saw what seemed like sensible rendering behavior.

Diff Detail

Repository

rP Phabricator

Branch

table1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23793
Build 32721: Run Core Tests
Build 32720: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 6 2020, 10:53 PM

Harbormaster completed remote builds in B23793: Diff 49968.Feb 6 2020, 10:54 PM

epriestley requested review of this revision.Feb 6 2020, 10:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2020, 11:01 PM

Closed by commit rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

blockrule/

PhutilRemarkupTableBlockRule.php

13 lines

Diff 49968

View Options

src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php

Respect linebreaks in full HTML tables in RemarkupClosedPublicActions