Differential D20968

Improve Remarkup parsing performance for certain large input blocks
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 10:37 PM.

Tags

None

Referenced Files

	F15423523: D20968.id49962.diff
	Sat, Mar 22, 3:48 PM

	F15390887: D20968.diff
	Sat, Mar 15, 7:12 AM

	F15315762: D20968.diff
	Thu, Mar 6, 6:09 PM

	Unknown Object (File)
	Sat, Feb 22, 2:41 PM

	Unknown Object (File)
	Feb 18 2025, 8:30 PM

	Unknown Object (File)
	Feb 18 2025, 8:29 PM

	Unknown Object (File)
	Feb 18 2025, 8:29 PM

	Unknown Object (File)
	Feb 18 2025, 8:21 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13487: Improve performance of remarkup block splitting
Commits: rPfdbe9ba149b6: Improve Remarkup parsing performance for certain large input blocks

Summary

Fixes T13487. In PHI1628, an install has a 4MB remarkup corpus which takes a long time to render. This is broadly expected, but a few reasonable improvements fell out of running it through the profiler.

Test Plan

Saw local cold-cache end-to-end rendering time drop from 12s to 4s for the highly secret input corpus.
Verified output has the same hashes before/after.
Ran all remarkup unit tests.

Diff Detail

Repository

Branch

remarkup1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php:200	XHP14	Misuse of `preg_quote`
Advice	src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php:213	XHP14	Misuse of `preg_quote`

Unit

Tests Passed

Build Status

Buildable 23787
Build 32712: Run Core Tests
Build 32711: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 4 2020, 10:37 PM

Harbormaster completed remote builds in B23787: Diff 49962.Feb 4 2020, 10:39 PM

epriestley requested review of this revision.Feb 4 2020, 10:39 PM

epriestley added inline comments.Feb 4 2020, 10:42 PM

src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php
250–254	This piece was pretty wild. It meant "Are both blocks default blocks (plain old paragraphs)?" but tested that in a very convoluted way.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 11:07 PM

Closed by commit rPfdbe9ba149b6: Improve Remarkup parsing performance for certain large input blocks (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPfdbe9ba149b6: Improve Remarkup parsing performance for certain large input blocks.

epriestley mentioned this in D21866: Addressing some PHP 8 incompatibilities - Remarkup.May 27 2023, 12:26 AM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

blockrule/

PhutilRemarkupNoteBlockRule.php

38 lines

remarkup/

PhutilRemarkupEngine.php

122 lines

rule/

PhabricatorObjectRemarkupRule.php

63 lines

Diff 49962

src/infrastructure/markup/blockrule/PhutilRemarkupNoteBlockRule.php

Loading...

src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php

Loading...

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php

Loading...