Page MenuHomePhabricator
Differential D20964

Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameter
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 3:51 PM.
Tags
None
Referenced Files
F15509937: D20964.id.diff
Wed, Apr 16, 5:39 PM
F15508099: D20964.id49955.diff
Wed, Apr 16, 1:37 AM
F15500975: D20964.id49954.diff
Sun, Apr 13, 8:04 PM
F15488977: D20964.id49955.diff
Fri, Apr 11, 4:49 AM
F15481887: D20964.diff
Wed, Apr 9, 12:03 AM
F15480780: D20964.id49955.diff
Tue, Apr 8, 4:26 PM
F15480580: D20964.id.diff
Tue, Apr 8, 3:01 PM
F15477332: D20964.diff
Mon, Apr 7, 1:32 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13485: Update GitHub integration for "access_token" deprecation changes
Commits
rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"…
Summary

Fixes T13485. GitHub has deprecated the "access_token" URI parameter for API authentication. Update to "Authorization: token ...".

Test Plan

Linked and unlinked a GitHub account locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 4 2020, 3:51 PM
Harbormaster completed remote builds in B23779: Diff 49954.Feb 4 2020, 3:53 PM
epriestley requested review of this revision.Feb 4 2020, 3:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 3:58 PM
Closed by commit rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"….

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
adapter/
6 lines

Diff 49955

View Options

src/applications/auth/adapter/PhutilGitHubAuthAdapter.php

Loading...
Phabricator · Built by Phacility