Page MenuHomePhabricator
Differential D20964

Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameter
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 3:51 PM.
Tags
None
Referenced Files
F15440836: D20964.id49954.diff
Wed, Mar 26, 2:53 PM
F15377251: D20964.id49955.diff
Thu, Mar 13, 8:28 AM
F15354222: D20964.id49955.diff
Tue, Mar 11, 2:38 AM
F15304548: D20964.id49955.diff
Thu, Mar 6, 1:52 AM
Unknown Object (File)
Fri, Feb 28, 3:35 AM
Unknown Object (File)
Thu, Feb 27, 9:06 AM
Unknown Object (File)
Wed, Feb 26, 12:51 PM
Unknown Object (File)
Wed, Feb 26, 9:54 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13485: Update GitHub integration for "access_token" deprecation changes
Commits
rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"…
Summary

Fixes T13485. GitHub has deprecated the "access_token" URI parameter for API authentication. Update to "Authorization: token ...".

Test Plan

Linked and unlinked a GitHub account locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 4 2020, 3:51 PM
Harbormaster completed remote builds in B23779: Diff 49954.Feb 4 2020, 3:53 PM
epriestley requested review of this revision.Feb 4 2020, 3:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 3:58 PM
Closed by commit rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"….

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
adapter/
6 lines

Diff 49955

View Options

src/applications/auth/adapter/PhutilGitHubAuthAdapter.php

Loading...
Phabricator · Built by Phacility