Differential D20964

Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameter
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 3:51 PM.

Tags

None

Referenced Files

	F18790533: D20964.id.diff
	Wed, Oct 15, 3:20 PM

	F18739059: D20964.id49955.diff
	Wed, Oct 1, 7:24 PM

	F18734138: D20964.id.diff
	Tue, Sep 30, 10:48 PM

	F18726932: D20964.id49954.diff
	Tue, Sep 30, 7:25 AM

	F18702112: D20964.diff
	Sat, Sep 27, 10:39 PM

	F18689759: D20964.id49954.diff
	Fri, Sep 26, 6:28 PM

	F18653054: D20964.id49955.diff
	Sun, Sep 21, 10:50 AM

	F18652954: D20964.id.diff
	Sun, Sep 21, 10:22 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13485: Update GitHub integration for "access_token" deprecation changes
Commits: rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"…

Summary

Fixes T13485. GitHub has deprecated the "access_token" URI parameter for API authentication. Update to "Authorization: token ...".

Test Plan

Linked and unlinked a GitHub account locally.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 4 2020, 3:51 PM

Harbormaster completed remote builds in B23779: Diff 49954.Feb 4 2020, 3:53 PM

epriestley requested review of this revision.Feb 4 2020, 3:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 3:58 PM

Closed by commit rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"….

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

adapter/

PhutilGitHubAuthAdapter.php

6 lines

Diff 49955

View Options

src/applications/auth/adapter/PhutilGitHubAuthAdapter.php

Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameterClosedPublicActions