Paths

Table of Contentst

Differential D20963

Fix an issue where loading a mangled project graph could fail too abruptly
ClosedPublic
Actions

Authored by epriestley on Feb 3 2020, 4:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 15, 4:19 PM

	Unknown Object (File)
	Sun, Feb 9, 8:35 AM

	Unknown Object (File)
	Sun, Feb 9, 8:35 AM

	Unknown Object (File)
	Sun, Feb 9, 8:35 AM

	Unknown Object (File)
	Sat, Jan 25, 6:25 AM

	Unknown Object (File)
	Sat, Jan 25, 6:24 AM

	Unknown Object (File)
	Sat, Jan 25, 6:24 AM

	Unknown Object (File)
	Sat, Jan 25, 5:10 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13484: Allow the policy layer to mark objects as damaged when filtering them
Commits: rPc42c5983aa6a: Fix an issue where loading a mangled project graph could fail too abruptly

Summary

Ref T13484. If you load a subproject S which has a mangled/invalid parentPath, the query currently tries to execute an empty edge query and fatals.

Instead, we want to deny-by-default in the policy layer but not fail the query. The subproject should become restricted but not fatal anything related to it.

See T13484 for a future refinement where we could identify "broken / data integrity issue" objects explicilty.

Test Plan

Modified the projectPath of some subproject in the database to QQQQ....
Loaded that project page.
Before patch: fatal after issuing bad edge query.
After patch: "functionally correct" policy layer failure, although an explicit "data integrity issue" failure would be better.

Diff Detail

Repository

Branch

integrity1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23770
Build 32689: Run Core Tests
Build 32688: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 3 2020, 4:45 PM

Harbormaster completed remote builds in B23770: Diff 49945.Feb 3 2020, 4:47 PM

epriestley requested review of this revision.Feb 3 2020, 4:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2020, 4:54 PM

Closed by commit rPc42c5983aa6a: Fix an issue where loading a mangled project graph could fail too abruptly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc42c5983aa6a: Fix an issue where loading a mangled project graph could fail too abruptly.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectQuery.php

19 lines

infrastructure/

edges/

query/

PhabricatorEdgeQuery.php

12 lines

Diff 49945

src/applications/project/query/PhabricatorProjectQuery.php

Loading...

src/infrastructure/edges/query/PhabricatorEdgeQuery.php

Loading...