Page MenuHomePhabricator

Update Herald rule creation workflow to use more modern UI elements
ClosedPublic

Authored by epriestley on Jan 29 2020, 8:40 PM.

Details

Summary

Ref T13480. Creating a rule in Herald currently uses the older radio-button flow. Update it to the "clickable menu" flow to simplify it a little bit.

Test Plan

Created new personal, object, and global rules. Hit the object rule error conditions.

Diff Detail

Repository
rP Phabricator
Branch
author8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23750
Build 32663: Run Core Tests
Build 32662: arc lint + arc unit

Event Timeline

  • Rebase and use "PHUILauncherView" in the new UIs.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 3:37 PM
This revision was automatically updated to reflect the committed changes.