Page MenuHomePhabricator

In Herald "Commit" rules, use repository identities to identify authors and committers
ClosedPublic

Authored by epriestley on Jan 29 2020, 6:40 PM.

Details

Summary

Ref T13480. The Herald "Commit" rules still use raw commit data properties to identify authors and committers. Instead, use repository identities.

Test Plan

Wrote a Herald rule using all four fields, ran it against various commits with and without known authors. Checked transcript for sensible field values.

Diff Detail

Repository
rP Phabricator
Branch
author7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23749
Build 32661: Run Core Tests
Build 32660: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:49 PM
This revision was automatically updated to reflect the committed changes.