Differential D20954

Don't use "line-through" style for completed items in remarkup checklists
ClosedPublic
Actions

Authored by epriestley on Jan 29 2020, 4:53 PM.

Details

Reviewers: None
Maniphest Tasks: T13482: Remove strikethru style from checked-off Remarkup list items
Commits: rP7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists

Summary

Fixes T13482. Although this style makes physical sense by relationship to a written checklist, it seems to do more harm than good in practice.

Test Plan

Wrote a checklist with a checked-off item in remarkup, saw no more line-through.

Diff Detail

Repository

rP Phabricator

Branch

check1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23747
Build 32658: Run Core Tests
Build 32657: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 29 2020, 4:53 PM

Harbormaster completed remote builds in B23747: Diff 49921.Jan 29 2020, 4:55 PM

epriestley requested review of this revision.Jan 29 2020, 4:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 4:59 PM

Closed by commit rP7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

core/

remarkup.css

1 line

Diff 49921

View Options

resources/celerity/map.php