Differential D20951

In Herald transcripts, render some field values in a more readable way
ClosedPublic
Actions

Authored by epriestley on Jan 23 2020, 11:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 18, 3:18 AM

	Unknown Object (File)
	Thu, Nov 14, 6:55 AM

	Unknown Object (File)
	Mon, Nov 11, 4:28 AM

	Unknown Object (File)
	Sun, Nov 10, 9:34 AM

	Unknown Object (File)
	Tue, Nov 5, 8:36 PM

	Unknown Object (File)
	Tue, Nov 5, 11:11 AM

	Unknown Object (File)
	Oct 22 2024, 12:48 PM

	Unknown Object (File)
	Oct 20 2024, 2:11 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields
Commits: rPa0a346be347e: In Herald transcripts, render some field values in a more readable way

Summary

Ref T13480. Currently, some Herald field types are rendered in an unfriendly way on transcripts. Particularly, PHID lists are rendered as raw PHIDs.

Improve this by delegating rendering to Value objects and letting "PHID List" value objects render more sensible handle lists. Also improve "bool" fields a bit and make more fields render an explicit "None" / empty value rather than just rendering nothing.

Test Plan

Viewed various transcripts, including transcripts covering boolean values, the "Always" condition, large blocks of text, and PHID lists.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 23 2020, 11:38 PM

Harbormaster completed remote builds in B23741: Diff 49915.Jan 23 2020, 11:40 PM

epriestley requested review of this revision.Jan 23 2020, 11:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:14 PM

Closed by commit rPa0a346be347e: In Herald transcripts, render some field values in a more readable way (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa0a346be347e: In Herald transcripts, render some field values in a more readable way.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

herald/

adapter/

HeraldAdapter.php

20 lines

controller/

HeraldTranscriptController.php

29 lines

field/

HeraldAlwaysField.php

2 lines

HeraldField.php

15 lines

value/

HeraldBoolFieldValue.php

30 lines

HeraldFieldValue.php

4 lines

HeraldTextFieldValue.php

21 lines

HeraldTokenizerFieldValue.php

37 lines

Diff 49928

src/__phutil_library_map__.php

Loading...

src/applications/herald/adapter/HeraldAdapter.php

Loading...

src/applications/herald/controller/HeraldTranscriptController.php

Loading...

src/applications/herald/field/HeraldAlwaysField.php

Loading...

src/applications/herald/field/HeraldField.php

Loading...

src/applications/herald/value/HeraldBoolFieldValue.php

Loading...

src/applications/herald/value/HeraldFieldValue.php

Loading...

src/applications/herald/value/HeraldTextFieldValue.php

Loading...

src/applications/herald/value/HeraldTokenizerFieldValue.php

Loading...