Page MenuHomePhabricator

In Herald transcript rendering, don't store display labels in keys
ClosedPublic

Authored by epriestley on Jan 23 2020, 7:51 PM.
Tags
None
Referenced Files
F13195321: D20949.diff
Sun, May 12, 10:18 PM
F13182305: D20949.diff
Thu, May 9, 10:48 PM
F13178109: D20949.diff
Wed, May 8, 8:11 PM
Unknown Object (File)
Tue, May 7, 6:04 PM
Unknown Object (File)
Mon, May 6, 11:47 PM
Unknown Object (File)
Thu, Apr 25, 1:29 AM
Unknown Object (File)
Sat, Apr 20, 5:00 PM
Unknown Object (File)
Sat, Apr 20, 12:23 AM
Subscribers
None

Details

Summary

Ref T13480. Currently, when Herald renders a transcript, it puts display labels into array keys. This is a bad pattern for several reasons, notably that the values must be scalar (so you can't add icons or other markup later) and the values must be unique (which is easily violated because many values are translated).

Instead, keep values as list items.

Test Plan

Viewed Herald transcripts, saw no (meaningful) change in rendering output.

Diff Detail

Repository
rP Phabricator
Branch
author4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23738
Build 32643: Run Core Tests
Build 32642: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:11 PM
This revision was automatically updated to reflect the committed changes.