Differential D20946

Add "Project tags added" and "Project tags removed" fields in Herald
ClosedPublic
Actions

Authored by epriestley on Jan 21 2020, 7:31 PM.

Tags

None

Referenced Files

	F14803796: D20946.diff
	Sat, Jan 25, 4:16 PM

	F14798633: D20946.id49909.diff
	Sat, Jan 25, 6:20 AM

	F14798632: D20946.id49907.diff
	Sat, Jan 25, 6:19 AM

	F14798631: D20946.id.diff
	Sat, Jan 25, 6:19 AM

	Unknown Object (File)
	Mon, Jan 6, 8:21 PM

	Unknown Object (File)
	Dec 16 2024, 5:26 PM

	Unknown Object (File)
	Dec 12 2024, 10:46 PM

	Unknown Object (File)
	Dec 11 2024, 10:20 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields
Commits: rP6c4500046f7c: Add "Project tags added" and "Project tags removed" fields in Herald

Summary

Ref T13480. These fields don't serve a specific strong use case, but are broadly reasonable capabilities after "state" vs "change" actions were relaxed by T13283.

Test Plan

Wrote rules using the new fields, added and removed projects (and did neither) to fire them / not fire them. Inspected the transcripts to see the project PHIDs making it to the field values.

Diff Detail

Repository

Branch

herald1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23733
Build 32635: Run Core Tests
Build 32634: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 21 2020, 7:31 PM

Harbormaster completed remote builds in B23733: Diff 49907.Jan 21 2020, 7:33 PM

epriestley requested review of this revision.Jan 21 2020, 7:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2020, 2:21 AM

Closed by commit rP6c4500046f7c: Add "Project tags added" and "Project tags removed" fields in Herald (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6c4500046f7c: Add "Project tags added" and "Project tags removed" fields in Herald.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

herald/

field/

HeraldField.php

45 lines

project/

herald/

HeraldProjectsField.php

19 lines

PhabricatorProjectTagsAddedField.php

23 lines

	PhabricatorProjectTagsField.php
	HeraldProjectsField.php

20 lines

PhabricatorProjectTagsRemovedField.php

23 lines

Diff 49907

src/__phutil_library_map__.php

Loading...

src/applications/herald/field/HeraldField.php

Loading...

src/applications/project/herald/HeraldProjectsField.php

Loading...

src/applications/project/herald/PhabricatorProjectTagsAddedField.php

Loading...

src/applications/project/herald/PhabricatorProjectTagsField.php

Loading...

src/applications/project/herald/PhabricatorProjectTagsRemovedField.php

Loading...