Page MenuHomePhabricator

Remove "stronger/weaker" policy color hints from object headers
ClosedPublic

Authored by epriestley on Nov 19 2019, 6:00 AM.
Tags
None
Referenced Files
F13087831: D20918.diff
Thu, Apr 25, 1:07 AM
Unknown Object (File)
Sat, Apr 20, 4:58 PM
Unknown Object (File)
Wed, Apr 17, 7:46 PM
Unknown Object (File)
Tue, Apr 16, 8:16 PM
Unknown Object (File)
Thu, Apr 11, 8:47 AM
Unknown Object (File)
Sun, Apr 7, 10:55 PM
Unknown Object (File)
Fri, Apr 5, 10:34 PM
Unknown Object (File)
Thu, Mar 28, 6:51 PM
Subscribers
None

Details

Summary

Fixes T13461. Some applications provide hints about policy strength in the header, but these hints are inconsistent and somewhat confusing. They don't make much sense for modern objects with Custom Forms, which don't have a single "default" policy.

Remove this feature since it seems to be confusing things more than illuminating them.

Test Plan
  • Viewed various objects, no longer saw colored policy hints.
  • Grepped for all removed symbols.

Diff Detail

Repository
rP Phabricator
Branch
policy2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23672
Build 32548: Run Core Tests
Build 32547: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 6:05 AM
This revision was automatically updated to reflect the committed changes.