Page MenuHomePhabricator

Prevent workboard cards from being grabbed by the "Txxx" object name text
ClosedPublic

Authored by epriestley on Nov 8 2019, 4:28 PM.
Tags
None
Referenced Files
F14798453: D20898.id49812.diff
Sat, Jan 25, 6:07 AM
F14798451: D20898.id49811.diff
Sat, Jan 25, 6:06 AM
F14798450: D20898.id.diff
Sat, Jan 25, 6:06 AM
Unknown Object (File)
Wed, Jan 22, 2:24 PM
Unknown Object (File)
Tue, Jan 21, 8:05 PM
Unknown Object (File)
Tue, Jan 21, 10:04 AM
Unknown Object (File)
Fri, Jan 17, 10:40 PM
Unknown Object (File)
Sun, Jan 12, 3:34 PM
Subscribers
None

Details

Summary

Fixes T13452. We currently give users mixed signals about the interaction mode of this text: the cursor says "text" but the behavior is "grab".

Make the behavior "text" to align with the cursor. An alternate variation of this change is to remove the cursor, but this is preferable if it doesn't cause problems, since copying the task ID is at least somewhat useful.

Test Plan

In Safari, Firefox, and Chrome: selected and copied object names from workboard cards; and dragged workboard cards by other parts of their UI.

Diff Detail

Repository
rP Phabricator
Branch
drag1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23639
Build 32496: Run Core Tests
Build 32495: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 8 2019, 4:29 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.