Differential D20879

Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not total tasks
ClosedPublic
Actions

Authored by epriestley on Oct 29 2019, 8:46 PM.

Tags

None

Referenced Files

	F13097507: D20879.diff
	Fri, Apr 26, 12:57 AM

	Unknown Object (File)
	Thu, Apr 25, 2:00 AM

	Unknown Object (File)
	Mon, Apr 22, 5:56 PM

	Unknown Object (File)
	Mon, Apr 22, 5:26 PM

	Unknown Object (File)
	Fri, Apr 19, 3:20 AM

	Unknown Object (File)
	Fri, Apr 19, 3:20 AM

	Unknown Object (File)
	Fri, Apr 19, 3:20 AM

	Unknown Object (File)
	Thu, Apr 11, 4:30 AM

View All 84 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13279: Build Charting for Facts
Commits: rP9d8cdce8e1f2: Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not…

Summary

Ref T13279. See PHI1491. Currently, the top-level "Burnup Rate" chart in Maniphest shows total created tasks above the X-axis, without adjusting for closures.

This is unintended and not very useful. The filtered-by-project charts show the right value (cumulative open tasks, i.e. open minus close). Change the value to aggregate creation events and status change events.

Test Plan

Viewed top-level chart, saw the value no longer monotonically increasing.

Diff Detail

Repository

Branch

burndown1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23604
Build 32444: Run Core Tests
Build 32443: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 29 2019, 8:46 PM

Harbormaster completed remote builds in B23604: Diff 49775.Oct 29 2019, 8:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2019, 8:48 PM

epriestley requested review of this revision.

Closed by commit rP9d8cdce8e1f2: Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP9d8cdce8e1f2: Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not….

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

chart/

PhabricatorProjectBurndownChartEngine.php

6 lines

Diff 49775

src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php

Loading...