Paths

Table of Contentst

Differential D20874

Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from modern sshd
ClosedPublic
Actions

Authored by epriestley on Oct 29 2019, 12:49 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 1:43 PM

	Unknown Object (File)
	Tue, Nov 19, 10:38 AM

	Unknown Object (File)
	Mon, Nov 18, 12:01 AM

	Unknown Object (File)
	Fri, Nov 15, 2:54 PM

	Unknown Object (File)
	Sun, Nov 10, 4:06 PM

	Unknown Object (File)
	Wed, Nov 6, 8:47 PM

	Unknown Object (File)
	Mon, Nov 4, 10:46 AM

	Unknown Object (File)
	Mon, Nov 4, 10:46 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13436: Improve performance of "ssh-auth"
Commits: rP5a4a1e8c9f13: (stable) Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading…
rP24f771c1bc07: Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from…

Summary

Depends on D20873. Ref T13436. Allow callers to configure "bin/ssh-auth --sshd-key %k" as an "AuthorizedKeysCommand"; if they do, and we recognize the key, emit just that key in the output.

Test Plan

Used git pull locally, still worked fine.
Instrumented things, saw the public key lookup actually work and emit a single key.
Ran without "--sshd-key", got a full key list as before.

Diff Detail

Repository

Branch

ssh-auth2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	scripts/ssh/ssh-auth.php:7	XHP16	TODO Comment

Unit

No Test Coverage

Build Status

Buildable 23590
Build 32425: Run Core Tests
Build 32424: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 29 2019, 12:49 AM

Harbormaster completed remote builds in B23590: Diff 49761.Oct 29 2019, 12:50 AM

epriestley requested review of this revision.Oct 29 2019, 12:50 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2019, 12:57 AM

Closed by commit rP24f771c1bc07: Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP24f771c1bc07: Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from….

epriestley added a commit: rP5a4a1e8c9f13: (stable) Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading….Oct 29 2019, 1:51 AM

Revision Contents
Changeset List

Path

Size

scripts/

ssh/

34 lines

Diff 49761

scripts/ssh/ssh-auth.php

Loading...