Page MenuHomePhabricator
Differential D20873

Remove the "ssh-auth-key" script
ClosedPublic
Actions

Authored by epriestley on Oct 29 2019, 12:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 8:51 PM
Unknown Object (File)
Mon, Nov 11, 10:43 AM
Unknown Object (File)
Mon, Nov 4, 10:46 AM
Unknown Object (File)
Mon, Nov 4, 10:46 AM
Unknown Object (File)
Mon, Nov 4, 10:46 AM
Unknown Object (File)
Mon, Nov 4, 10:46 AM
Unknown Object (File)
Mon, Nov 4, 7:23 AM
Unknown Object (File)
Sun, Nov 3, 2:00 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13436: Improve performance of "ssh-auth"
Commits
rP257830ae71d1: (stable) Remove the "ssh-auth-key" script
rP02f85f03bda7: Remove the "ssh-auth-key" script
Summary

Ref T13436. Historically, this script could be used with a forked copy of "sshd" to do lower-cost per-key auth.

Relatively modern "sshd" supports "%f" to "AuthorizedKeysCommand", which effectively moots this.

Users have never been instructed to use this script for anything, and we moved away from this specific patch to "sshd" some time ago.

Test Plan

Grepped for "ssh-auth-key", no hits.

Diff Detail

Repository
rP Phabricator
Branch
ssh-auth1
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23588
Build 32421: Run Core Tests
Build 32420: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 29 2019, 12:36 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 29 2019, 12:36 AM
Harbormaster failed remote builds in B23588: Diff 49759!
epriestley updated this revision to Diff 49760.Oct 29 2019, 12:38 AM
  • Update to hit staging after rebuilding repository index.
Harbormaster completed remote builds in B23589: Diff 49760.Oct 29 2019, 12:39 AM
epriestley requested review of this revision.Oct 29 2019, 12:39 AM
epriestley added a child revision: D20874: Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from modern sshd.Oct 29 2019, 12:49 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2019, 12:52 AM
Closed by commit rP02f85f03bda7: Remove the "ssh-auth-key" script (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP02f85f03bda7: Remove the "ssh-auth-key" script.
epriestley added a commit: rP257830ae71d1: (stable) Remove the "ssh-auth-key" script.Oct 29 2019, 1:51 AM

Revision Contents
Changeset List

PathSize
bin/
scripts/
ssh/

Diff 49759

View Options

bin/ssh-auth-key

Loading...
View Options

scripts/ssh/ssh-auth-key.php

Loading...
Phabricator · Built by Phacility