Page MenuHomePhabricator

In "arc land", when "remote/onto" does not exist locally, try to fetch it before giving up
ClosedPublic

Authored by epriestley on Oct 28 2019, 6:20 PM.
Tags
None
Referenced Files
F13226424: D20870.id49754.diff
Sun, May 19, 8:39 PM
F13194300: D20870.id.diff
Sun, May 12, 9:28 PM
F13191946: D20870.diff
Sun, May 12, 3:05 AM
Unknown Object (File)
Tue, May 7, 7:47 AM
Unknown Object (File)
Sun, May 5, 11:04 PM
Unknown Object (File)
Fri, May 3, 7:24 AM
Unknown Object (File)
Sat, Apr 27, 3:37 PM
Unknown Object (File)
Thu, Apr 25, 1:31 AM
Subscribers
None

Details

Summary

Fixes T10650. It's valid to arc land --remote origin --onto master without first fetching that ref. If we can't find a local ref for a specified remote branch, try to fetch it before giving up.

(In the long run, this should be valid even if the remote branch does not exist at all and the user intends to create it -- see T12876 -- but this is a step toward that.)

Test Plan
  • Ran rm .git/refs/remotes/origin/master, then landed into "master".
  • Before: "arc land" bailed out immediately.
  • After: "arc land" fetches the missing ref.
$ arc land
 TARGET  Landing onto "master", the default target under git.
 REMOTE  Using remote "origin", the default remote under Git.
 TARGET  No local ref exists for branch "master" in remote "origin", attempting fetch...
 FETCHED  Fetched branch "master" from remote "origin".
...

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2019, 6:31 PM
This revision was automatically updated to reflect the committed changes.