Differential D20812

Work around rendering engine freeze in Chrome 77 affecting workboards
ClosedPublic
Actions

Authored by epriestley on Sep 13 2019, 1:59 AM.

Details

Reviewers: None
Maniphest Tasks: T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior
Commits: rP3dcb4a7b5036: Work around rendering engine freeze in Chrome 77 affecting workboards

Summary

Ref T13413. In Chrome 77, workboard cards with titles that must break in the middle of words cause the browser to completely lock up.

Work around the major known instance of this by overriding the "break-word" behavior. This gives us worse rendering for tasks with very long "words" in their titles (they are truncated instead of broken) but fixes the freezing.

Once Chrome is fixed, this can be reverted.

Test Plan

Created a task named "MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM" on a workboard.
Loaded the board in Chrome 77.
Before: entire page locks up.
After: smooth sailing, except the "MMMMMM..." is truncated.

Diff Detail

Repository

rP Phabricator

Branch

chrome1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23445
Build 32212: Run Core Tests
Build 32211: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 13 2019, 1:59 AM

Harbormaster completed remote builds in B23445: Diff 49620.Sep 13 2019, 2:00 AM

epriestley requested review of this revision.Sep 13 2019, 2:00 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 13 2019, 2:04 AM

Closed by commit rP3dcb4a7b5036: Work around rendering engine freeze in Chrome 77 affecting workboards (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP3dcb4a7b5036: Work around rendering engine freeze in Chrome 77 affecting workboards.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

phui/

workboards/

phui-workcard.css

4 lines

Diff 49620

View Options

resources/celerity/map.php