Paths

Table of Contentst

Differential D20810

Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action
ClosedPublic
Actions

Authored by epriestley on Sep 12 2019, 11:12 PM.

Tags

None

Referenced Files

	F13196297: D20810.diff
	Sun, May 12, 11:09 PM

	F13183512: D20810.id49616.diff
	Fri, May 10, 9:49 AM

	Unknown Object (File)
	Fri, May 3, 3:43 AM

	Unknown Object (File)
	Fri, May 3, 12:05 AM

	Unknown Object (File)
	Mon, Apr 29, 3:45 PM

	Unknown Object (File)
	Fri, Apr 26, 1:14 PM

	Unknown Object (File)
	Wed, Apr 24, 11:43 PM

	Unknown Object (File)
	Mar 30 2024, 1:23 AM

View All 70 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis
Commits: rP41f0b8b0a3a1: Allow subtypes to specify "mutations", to control the behavior of the "Change…

Summary

Fixes T13415. Provide a way for subtypes to customize the behavior of "Change Subtype" actions that appear above comment areas.

Subtypes may disable this action by specifying "mutations": [], or provide a list of subtypes.

The bulk editor and API can still perform any change.

Test Plan

Tried to define an invalid "mutations" list with a bad subtype, got a sensible error.
Specified a limited mutations list and an empty mutations list, verified that corresponding tasks got corresponding actions.
Used the bulk editor to perform a freeform mutation.
Verified that tasks of a subtype with no "mutations" still work the same way they used to (allow mutation into any subtype).

Diff Detail

Repository

Branch

subtype1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23441
Build 32206: Run Core Tests
Build 32205: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 12 2019, 11:12 PM

Harbormaster completed remote builds in B23441: Diff 49616.Sep 12 2019, 11:13 PM

epriestley requested review of this revision.Sep 12 2019, 11:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 11:17 PM

Closed by commit rP41f0b8b0a3a1: Allow subtypes to specify "mutations", to control the behavior of the "Change… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP41f0b8b0a3a1: Allow subtypes to specify "mutations", to control the behavior of the "Change….

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

config/

PhabricatorManiphestConfigOptions.php

41 lines

transactions/

editengine/

PhabricatorEditEngineSubtype.php

35 lines

PhabricatorEditEngineSubtypeMap.php

38 lines

engineextension/

PhabricatorSubtypeEditEngineExtension.php

18 lines

Diff 49616

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php

Loading...

src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php

Loading...