Differential D20809

Support "Subtype" in Herald
ClosedPublic
Actions

Authored by epriestley on Sep 12 2019, 8:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 8:04 PM

	Unknown Object (File)
	Sun, Dec 15, 1:57 PM

	Unknown Object (File)
	Sun, Dec 15, 2:46 AM

	Unknown Object (File)
	Sat, Dec 14, 6:27 PM

	Unknown Object (File)
	Thu, Dec 12, 10:11 PM

	Unknown Object (File)
	Sun, Dec 8, 12:29 PM

	Unknown Object (File)
	Sat, Dec 7, 11:05 AM

	Unknown Object (File)
	Thu, Dec 5, 1:18 AM

Subscribers

None

Details

Reviewers: None
Commits: rP3e6012803725: Support "Subtype" in Herald

Summary

See PHI1434. For objects that support subtypes and have subtypes configured, allow Herald rules to act on subtypes.

Test Plan

Configured task and project subtypes, wrote Herald rules, saw "Subtypes" as an option, saw appropriate typeahead values and detail page rendering.
Unconfigured project subtypes, saw field vanish from UI for new rules.
Wrote a "subtype"-depenent rule that added a comment, interacted with tasks of that subtype and a different subtype. Saw Herald act only on tasks with the correct subtype.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 12 2019, 8:17 PM

Harbormaster completed remote builds in B23438: Diff 49613.Sep 12 2019, 8:18 PM

epriestley requested review of this revision.Sep 12 2019, 8:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 9:34 PM

Closed by commit rP3e6012803725: Support "Subtype" in Herald (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP3e6012803725: Support "Subtype" in Herald.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

maniphest/

storage/

ManiphestTask.php

3 lines

project/

storage/

PhabricatorProject.php

3 lines

transactions/

editengine/

PhabricatorEditEngineSubtypeMap.php

14 lines

herald/

PhabricatorEditEngineSubtypeHeraldField.php

52 lines

Diff 49615

src/__phutil_library_map__.php

Loading...

src/applications/maniphest/storage/ManiphestTask.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php

Loading...

src/applications/transactions/herald/PhabricatorEditEngineSubtypeHeraldField.php

Loading...