Page MenuHomePhabricator

Support "Subtype" in Herald
ClosedPublic

Authored by epriestley on Sep 12 2019, 8:17 PM.

Details

Summary

See PHI1434. For objects that support subtypes and have subtypes configured, allow Herald rules to act on subtypes.

Test Plan
  • Configured task and project subtypes, wrote Herald rules, saw "Subtypes" as an option, saw appropriate typeahead values and detail page rendering.
  • Unconfigured project subtypes, saw field vanish from UI for new rules.
  • Wrote a "subtype"-depenent rule that added a comment, interacted with tasks of that subtype and a different subtype. Saw Herald act only on tasks with the correct subtype.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 12 2019, 8:17 PM
epriestley requested review of this revision.Sep 12 2019, 8:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 9:34 PM
This revision was automatically updated to reflect the committed changes.