Page MenuHomePhabricator

Support "Subtype" in Herald
ClosedPublic

Authored by epriestley on Sep 12 2019, 8:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 26 2024, 1:53 PM
Unknown Object (File)
Jan 9 2024, 8:21 AM
Unknown Object (File)
Jan 5 2024, 1:28 PM
Unknown Object (File)
Dec 26 2023, 9:56 PM
Unknown Object (File)
Dec 24 2023, 7:39 PM
Unknown Object (File)
Dec 24 2023, 3:46 AM
Unknown Object (File)
Dec 22 2023, 12:38 PM
Unknown Object (File)
Dec 10 2023, 11:09 AM
Subscribers
None

Details

Summary

See PHI1434. For objects that support subtypes and have subtypes configured, allow Herald rules to act on subtypes.

Test Plan
  • Configured task and project subtypes, wrote Herald rules, saw "Subtypes" as an option, saw appropriate typeahead values and detail page rendering.
  • Unconfigured project subtypes, saw field vanish from UI for new rules.
  • Wrote a "subtype"-depenent rule that added a comment, interacted with tasks of that subtype and a different subtype. Saw Herald act only on tasks with the correct subtype.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 9:34 PM
This revision was automatically updated to reflect the committed changes.