Page MenuHomePhabricator

When users encounter a policy exception for a non-view capability with a custom policy, inline the policy rules
ClosedPublic

Authored by epriestley on Sep 12 2019, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 11:00 AM
Unknown Object (File)
Feb 17 2024, 11:09 AM
Unknown Object (File)
Dec 21 2023, 10:14 PM
Unknown Object (File)
Dec 20 2023, 6:58 PM
Unknown Object (File)
Dec 13 2023, 12:42 PM
Unknown Object (File)
Nov 30 2023, 4:27 AM
Unknown Object (File)
Nov 25 2023, 10:37 PM
Unknown Object (File)
Nov 17 2023, 8:38 AM
Subscribers
None

Details

Summary

Fixes T13411. This looks like the last case where you hit a policy explanation and have permission to see the policy, but we don't currently show you the policy rules.

This implementation is slightly clumsy, but likely harmless.

Test Plan

Screen Shot 2019-09-12 at 9.28.22 AM.png (1×2 px, 357 KB)

Diff Detail

Repository
rP Phabricator
Branch
policy7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/policy/filter/PhabricatorPolicyFilter.php:656XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23428
Build 32190: Run Core Tests
Build 32189: arc lint + arc unit