Differential D20807

When users encounter a policy exception for a non-view capability with a custom policy, inline the policy rules
ClosedPublic
Actions

Authored by epriestley on Sep 12 2019, 4:30 PM.

Details

Reviewers: None
Maniphest Tasks: T13411: Improve "Custom Policy" behavior in policy dialogs
Commits: rP4f845d8f8c77: When users encounter a policy exception for a non-view capability with a custom…

Summary

Fixes T13411. This looks like the last case where you hit a policy explanation and have permission to see the policy, but we don't currently show you the policy rules.

This implementation is slightly clumsy, but likely harmless.

Test Plan

Screen Shot 2019-09-12 at 9.28.22 AM.png (1×2 px, 357 KB)

Diff Detail

Repository

rP Phabricator

Branch

policy7

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/policy/filter/PhabricatorPolicyFilter.php:656	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23428
Build 32190: Run Core Tests
Build 32189: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 12 2019, 4:30 PM

Harbormaster completed remote builds in B23428: Diff 49603.Sep 12 2019, 4:32 PM

epriestley requested review of this revision.Sep 12 2019, 4:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:49 PM

Closed by commit rP4f845d8f8c77: When users encounter a policy exception for a non-view capability with a custom… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP4f845d8f8c77: When users encounter a policy exception for a non-view capability with a custom….

Revision Contents
Changeset List

Path

Size

src/

applications/

policy/

filter/

PhabricatorPolicyFilter.php

45 lines

Diff 49603

View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

When users encounter a policy exception for a non-view capability with a custom policy, inline the policy rulesClosedPublicActions