Page MenuHomePhabricator
Differential D20803

Remove unused "icon" parameter from policy name rendering
ClosedPublic
Actions

Authored by epriestley on Sep 12 2019, 2:08 PM.
Tags
None
Referenced Files
F15462665: D20803.diff
Tue, Apr 1, 4:34 PM
F15456307: D20803.id.diff
Sun, Mar 30, 8:33 AM
F15414562: D20803.diff
Thu, Mar 20, 1:12 AM
Unknown Object (File)
Feb 11 2025, 5:33 AM
Unknown Object (File)
Feb 9 2025, 8:07 AM
Unknown Object (File)
Feb 9 2025, 8:07 AM
Unknown Object (File)
Feb 9 2025, 8:07 AM
Unknown Object (File)
Jan 25 2025, 5:45 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13411: Improve "Custom Policy" behavior in policy dialogs
Commits
rPc9b0d107f079: Remove unused "icon" parameter from policy name rendering
Summary

Ref T13411. This pathway has an unused "icon" parameter with no callsites. Throw it away to ease refactoring.

Test Plan

Grepped for callsites, found none using this parameter.

Diff Detail

Repository
rP Phabricator
Branch
policy3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23424
Build 32182: Run Core Tests
Build 32181: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 12 2019, 2:08 PM
Harbormaster completed remote builds in B23424: Diff 49599.Sep 12 2019, 2:10 PM
epriestley requested review of this revision.Sep 12 2019, 2:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:38 PM
Closed by commit rPc9b0d107f079: Remove unused "icon" parameter from policy name rendering (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc9b0d107f079: Remove unused "icon" parameter from policy name rendering.

Revision Contents
Changeset List

PathSize
src/
applications/
policy/
controller/
4 lines
query/
5 lines
storage/
19 lines

Diff 49599

View Options

src/applications/policy/controller/PhabricatorPolicyExplainController.php

Loading...
View Options

src/applications/policy/query/PhabricatorPolicyQuery.php

Loading...
View Options

src/applications/policy/storage/PhabricatorPolicy.php

Loading...
Phabricator · Built by Phacility