Differential D20797

When Herald changes object subscribers, always hide the feed story
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 8:14 PM.

Details

Reviewers: None
Maniphest Tasks: T8952: Hide "Herald added subscribers..." stories from feed completely
Commits: rP7593a265d593: When Herald changes object subscribers, always hide the feed story

Summary

Fixes T8952. These feed stories are not interesting and tend to be generated as collateral damage when a non-story update is made to an old task and someone has a "subscribe me" Herald rule.

Also clean up some of the Herald field/condition indexing behavior slightly.

Test Plan

Wrote a "Subscribe X" herald rule, made a trivial update to a task. Before: low-value feed story; after: no feed story.

Diff Detail

Repository

rP Phabricator

Branch

subs1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23413
Build 32165: Run Core Tests
Build 32164: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 9 2019, 8:14 PM

Harbormaster completed remote builds in B23413: Diff 49588.Sep 9 2019, 8:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:15 PM

epriestley requested review of this revision.

Closed by commit rP7593a265d593: When Herald changes object subscribers, always hide the feed story (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7593a265d593: When Herald changes object subscribers, always hide the feed story.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

field/

HeraldField.php

23 lines

transactions/

storage/

PhabricatorApplicationTransaction.php

13 lines

Diff 49588

View Options

src/applications/herald/field/HeraldField.php