Page MenuHomePhabricator

Fix fatal during redirection safety check for searching for Phabricator base-uri with no trailing slash
ClosedPublic

Authored by epriestley on Sep 9 2019, 7:30 PM.

Details

Summary

Fixes T13412. If you search for "https://phabricator.example.com" with no trailing slash, we currently redirect you to "", which is fouled by a safety check in the redirection flow.

Test Plan
  • Searched for "https://local.phacility.com"; before: fatal in redirection; after: clean redirect.
  • Searched for other self-URIs, got normal redirects.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 9 2019, 7:30 PM
epriestley requested review of this revision.Sep 9 2019, 7:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:45 PM
This revision was automatically updated to reflect the committed changes.