Page MenuHomePhabricator

Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES"
ClosedPublic

Authored by epriestley on Sep 8 2019, 8:02 PM.
Tags
None
Referenced Files
F14843688: D20791.id49571.diff
Sun, Feb 2, 9:01 AM
Unknown Object (File)
Thu, Jan 30, 11:43 PM
Unknown Object (File)
Thu, Jan 30, 10:41 AM
Unknown Object (File)
Sun, Jan 26, 7:26 AM
Unknown Object (File)
Sat, Jan 25, 5:42 AM
Unknown Object (File)
Sat, Jan 25, 5:41 AM
Unknown Object (File)
Sat, Jan 25, 5:41 AM
Unknown Object (File)
Thu, Jan 23, 12:02 AM
Subscribers
None

Details

Summary

Ref T13404. Except for one known issue in Multimeter, Phabricator appears to function properly in this mode. It is broadly desirable that we run in this mode; it's good on its own, and enabled by default in at least some recent MySQL.

Additionally, "ONLY_FULL_GROUP_BY" and "STRICT_ALL_TABLES" shared a setup key, so ignoring one would ignore both. Change the key so that existing ignores on "ONLY_FULL_GROUP_BY" do not mask "STRICT_ALL_TABLES" warnings.

Test Plan

Grepped for ONLY_FULL_GROUP_BY.

Diff Detail

Repository
rP Phabricator
Branch
strict2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23397
Build 32143: Run Core Tests
Build 32142: arc lint + arc unit