Ref T13404. This query is invalid under "sql_mode=ONLY_FULL_GROUP_BY". Rewrite it to avoid interacting with actorIdentity at all; this is a little more robust in the presence of weird data and not really more complicated.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY
- Commits
- rP22b075df9716: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries
- Enabled "ONLY_FULL_GROUP_BY".
- Hit system actions (e.g., login).
- Before: error.
- After: clean login.
- Tried to login with a bad password many times in a row, got properly limited by the system action rate limiter.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- group1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 23379 Build 32116: Run Core Tests Build 32115: arc lint + arc unit