Paths

Table of Contentst

Differential D20745

Allow HTTPSFuture to stream very large files directly to disk
ClosedPublic
Actions

Authored by epriestley on Aug 29 2019, 5:38 PM.

Tags

None

Referenced Files

	F16895977: D20745.diff
	Wed, Jun 18, 2:02 PM

	Unknown Object (File)
	May 6 2025, 4:04 AM

	Unknown Object (File)
	Apr 21 2025, 4:08 AM

	Unknown Object (File)
	Apr 13 2025, 7:49 AM

	Unknown Object (File)
	Apr 4 2025, 2:58 PM

	Unknown Object (File)
	Mar 30 2025, 1:17 PM

	Unknown Object (File)
	Mar 29 2025, 6:05 AM

	Unknown Object (File)
	Mar 28 2025, 4:25 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13396: Support downloads of 2GB+ files with HTTPSFuture
Commits: rPHUdb94ec322abf: (stable) Allow HTTPSFuture to stream very large files directly to disk
rPHU45c553b5c1d5: Allow HTTPSFuture to stream very large files directly to disk

Summary

Ref T13396. Support a mode which directs "HTTPSFuture" to stream response bodies to disk. In this mode, use the new streaming parser to break past the 2GB limit.

Test Plan

Ran various HTTP commands to attempt to establish that this does not change any existing behavior.
In the next change (internal), modified bin/host download to use this pathway and downloaded large files.

Diff Detail

Repository

Branch

http1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23321
Build 32043: Run Core Tests
Build 32042: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 29 2019, 5:38 PM

Harbormaster completed remote builds in B23321: Diff 49462.Aug 29 2019, 5:38 PM

epriestley requested review of this revision.Aug 29 2019, 5:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2019, 7:06 PM

Closed by commit rPHU45c553b5c1d5: Allow HTTPSFuture to stream very large files directly to disk (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU45c553b5c1d5: Allow HTTPSFuture to stream very large files directly to disk.

epriestley added a commit: rPHUdb94ec322abf: (stable) Allow HTTPSFuture to stream very large files directly to disk.

Revision Contents
Changeset List

Path

Size

src/

future/

http/

HTTPSFuture.php

105 lines

parser/

http/

PhutilHTTPResponse.php

24 lines

PhutilHTTPResponseParser.php

18 lines

Diff 49462

src/future/http/HTTPSFuture.php

Loading...

src/parser/http/PhutilHTTPResponse.php

Loading...

src/parser/http/PhutilHTTPResponseParser.php

Loading...